Re: [PATCH net-next 3/3] mlxsw: Add extack messages for port_{un,}split failures?

2018-06-05 Thread Jiri Pirko
Tue, Jun 05, 2018 at 04:58:44PM CEST, dsah...@gmail.com wrote: >On 6/5/18 1:18 AM, Jiri Pirko wrote: >> Tue, Jun 05, 2018 at 10:05:28AM CEST, ido...@idosch.org wrote: >>> On Tue, Jun 05, 2018 at 09:52:30AM +0200, Jiri Pirko wrote: Tue, Jun 05, 2018 at 12:15:03AM CEST, dsah...@kernel.org

Re: [PATCH net-next 3/3] mlxsw: Add extack messages for port_{un,}split failures?

2018-06-05 Thread David Miller
From: David Ahern Date: Tue, 5 Jun 2018 07:58:44 -0700 > On 6/5/18 1:18 AM, Jiri Pirko wrote: >> Tue, Jun 05, 2018 at 10:05:28AM CEST, ido...@idosch.org wrote: >>> On Tue, Jun 05, 2018 at 09:52:30AM +0200, Jiri Pirko wrote: Tue, Jun 05, 2018 at 12:15:03AM CEST, dsah...@kernel.org wrote:

Re: [PATCH net-next 3/3] mlxsw: Add extack messages for port_{un,}split failures?

2018-06-05 Thread David Ahern
On 6/5/18 1:18 AM, Jiri Pirko wrote: > Tue, Jun 05, 2018 at 10:05:28AM CEST, ido...@idosch.org wrote: >> On Tue, Jun 05, 2018 at 09:52:30AM +0200, Jiri Pirko wrote: >>> Tue, Jun 05, 2018 at 12:15:03AM CEST, dsah...@kernel.org wrote: if (!mlxsw_sp_port->split) {

Re: [PATCH net-next 3/3] mlxsw: Add extack messages for port_{un,}split failures?

2018-06-05 Thread David Miller
From: Jiri Pirko Date: Tue, 5 Jun 2018 10:18:36 +0200 > Tue, Jun 05, 2018 at 10:05:28AM CEST, ido...@idosch.org wrote: >>On Tue, Jun 05, 2018 at 09:52:30AM +0200, Jiri Pirko wrote: >>> Tue, Jun 05, 2018 at 12:15:03AM CEST, dsah...@kernel.org wrote: >>> > if (!mlxsw_sp_port->split) { >>> >

Re: [PATCH net-next 3/3] mlxsw: Add extack messages for port_{un,}split failures?

2018-06-05 Thread Jiri Pirko
Tue, Jun 05, 2018 at 10:05:28AM CEST, ido...@idosch.org wrote: >On Tue, Jun 05, 2018 at 09:52:30AM +0200, Jiri Pirko wrote: >> Tue, Jun 05, 2018 at 12:15:03AM CEST, dsah...@kernel.org wrote: >> >if (!mlxsw_sp_port->split) { >> >netdev_err(mlxsw_sp_port->dev, "Port wasn't split\n");

Re: [PATCH net-next 3/3] mlxsw: Add extack messages for port_{un,}split failures?

2018-06-05 Thread Ido Schimmel
On Tue, Jun 05, 2018 at 09:52:30AM +0200, Jiri Pirko wrote: > Tue, Jun 05, 2018 at 12:15:03AM CEST, dsah...@kernel.org wrote: > > if (!mlxsw_sp_port->split) { > > netdev_err(mlxsw_sp_port->dev, "Port wasn't split\n"); > >+NL_SET_ERR_MSG_MOD(extack, "Port was not

Re: [PATCH net-next 3/3] mlxsw: Add extack messages for port_{un,}split failures

2018-06-05 Thread Jiri Pirko
Tue, Jun 05, 2018 at 12:15:03AM CEST, dsah...@kernel.org wrote: >From: David Ahern > >Return messages in extack for port split/unsplit errors. e.g., >$ devlink port split swp1s1 count 4 >Error: mlxsw_spectrum: Port cannot be split further. >devlink answers: Invalid argument > >$

Re: [PATCH net-next 3/3] mlxsw: Add extack messages for port_{un,}split failures

2018-06-04 Thread Ido Schimmel
On Mon, Jun 04, 2018 at 03:15:03PM -0700, dsah...@kernel.org wrote: > From: David Ahern > > Return messages in extack for port split/unsplit errors. e.g., > $ devlink port split swp1s1 count 4 > Error: mlxsw_spectrum: Port cannot be split further. > devlink answers: Invalid argument

[PATCH net-next 3/3] mlxsw: Add extack messages for port_{un,}split failures

2018-06-04 Thread dsahern
From: David Ahern Return messages in extack for port split/unsplit errors. e.g., $ devlink port split swp1s1 count 4 Error: mlxsw_spectrum: Port cannot be split further. devlink answers: Invalid argument $ devlink port unsplit swp4 Error: mlxsw_spectrum: Port was not split.