Re: [PATCH net-next 3/3] mlxsw: spectrum_router: Return extack message on abort due to fib rules

2017-10-26 Thread David Ahern
On 10/26/17 12:38 AM, Ido Schimmel wrote: > > Nice idea, but one problem is that the FIB notifier is atomic and thus > when you trigger abort you end up sleeping in an atomic context: > ... > > How about we keep the checking and error reporting inline, but do the > actual abort in a workqueue?

Re: [PATCH net-next 3/3] mlxsw: spectrum_router: Return extack message on abort due to fib rules

2017-10-26 Thread Ido Schimmel
On Thu, Oct 26, 2017 at 08:26:16AM +0200, Jiri Pirko wrote: > Thu, Oct 26, 2017 at 07:08:05AM CEST, dsah...@gmail.com wrote: > >Adding a FIB rule on a spectrum platform silently aborts FIB offload: > >$ ip ru add pref 99 from all to 192.168.1.1 table 10 > >$ dmesg -c > >[ 623.144736]

Re: [PATCH net-next 3/3] mlxsw: spectrum_router: Return extack message on abort due to fib rules

2017-10-26 Thread Ido Schimmel
Hi David, On Wed, Oct 25, 2017 at 10:08:05PM -0700, David Ahern wrote: > Adding a FIB rule on a spectrum platform silently aborts FIB offload: > $ ip ru add pref 99 from all to 192.168.1.1 table 10 > $ dmesg -c > [ 623.144736] mlxsw_spectrum :03:00.0: FIB abort triggered. Note >

Re: [PATCH net-next 3/3] mlxsw: spectrum_router: Return extack message on abort due to fib rules

2017-10-26 Thread Jiri Pirko
Thu, Oct 26, 2017 at 07:08:05AM CEST, dsah...@gmail.com wrote: >Adding a FIB rule on a spectrum platform silently aborts FIB offload: >$ ip ru add pref 99 from all to 192.168.1.1 table 10 >$ dmesg -c >[ 623.144736] mlxsw_spectrum :03:00.0: FIB abort triggered. Note that > FIB

[PATCH net-next 3/3] mlxsw: spectrum_router: Return extack message on abort due to fib rules

2017-10-25 Thread David Ahern
Adding a FIB rule on a spectrum platform silently aborts FIB offload: $ ip ru add pref 99 from all to 192.168.1.1 table 10 $ dmesg -c [ 623.144736] mlxsw_spectrum :03:00.0: FIB abort triggered. Note that FIB entries are no longer being offloaded to this device. This patch