Re: [PATCH net-next 3/3] net: dsa: refine netdev event notifier

Sun, Mar 13, 2016 at 10:21:34PM IST, vivien.dide...@savoirfairelinux.com wrote: >Rework the netdev event handler, similar to what the Mellanox Spectrum >driver does, to easily welcome more events later (for example >NETDEV_PRECHANGEUPPER) and use netdev helpers (such as >netif_is_bridge_master). >

Re: [PATCH net-next 3/3] net: dsa: refine netdev event notifier

Sun, Mar 13, 2016 at 09:21:34PM CET, vivien.dide...@savoirfairelinux.com wrote: >Rework the netdev event handler, similar to what the Mellanox Spectrum >driver does, to easily welcome more events later (for example >NETDEV_PRECHANGEUPPER) and use netdev helpers (such as >netif_is_bridge_master). >

[PATCH net-next 3/3] net: dsa: refine netdev event notifier

Rework the netdev event handler, similar to what the Mellanox Spectrum driver does, to easily welcome more events later (for example NETDEV_PRECHANGEUPPER) and use netdev helpers (such as netif_is_bridge_master). Signed-off-by: Vivien Didelot ---

Re: [RFC PATCH net-next 3/3] net: dsa: refine netdev event notifier

Hi Ido, Ido Schimmel writes: >>+ case NETDEV_PRECHANGEUPPER: > > Why do you need this here? It seems you are always ignoring it in > dsa_slave_port_upper_event()? Probably better to introduce it when you > actually need it. > > Other than that, it looks good to me.

Re: [RFC PATCH net-next 3/3] net: dsa: refine netdev event notifier

Hi Vivien, Sun, Mar 13, 2016 at 08:42:26AM IST, vivien.dide...@savoirfairelinux.com wrote: >Rework the netdev event handler, similar to what the Mellanox Spectrum >driver does, to eventually welcome NETDEV_PRECHANGEUPPER actions and use >netdev helpers, such as netif_is_bridge_master. >

[RFC PATCH net-next 3/3] net: dsa: refine netdev event notifier

Rework the netdev event handler, similar to what the Mellanox Spectrum driver does, to eventually welcome NETDEV_PRECHANGEUPPER actions and use netdev helpers, such as netif_is_bridge_master. Signed-off-by: Vivien Didelot --- net/dsa/slave.c | 55