Re: [PATCH net-next 3/7] net: dsa: get port type at parse time

2017-10-30 Thread Florian Fainelli
On 10/30/2017 11:46 AM, Vivien Didelot wrote: > Hi Florian, > > Florian Fainelli writes: > >> Reviewed-by: Florian Fainelli >> >> One nit below: >> >>> static int dsa_port_parse_of(struct dsa_port *dp, struct device_node *dn) >>> { >>> + struct

Re: [PATCH net-next 3/7] net: dsa: get port type at parse time

2017-10-30 Thread Vivien Didelot
Hi Florian, Florian Fainelli writes: > Reviewed-by: Florian Fainelli > > One nit below: > >> static int dsa_port_parse_of(struct dsa_port *dp, struct device_node *dn) >> { >> +struct device_node *ethernet = of_parse_phandle(dn, "ethernet", 0);

Re: [PATCH net-next 3/7] net: dsa: get port type at parse time

2017-10-30 Thread Florian Fainelli
On 10/27/2017 12:55 PM, Vivien Didelot wrote: > Assign a port's type at parsed time instead of waiting for the tree to > be completed. > > Because this is now done earlier, we can use the port's type in > dsa_port_is_* helpers instead of digging again in topology description. > > Signed-off-by:

[PATCH net-next 3/7] net: dsa: get port type at parse time

2017-10-27 Thread Vivien Didelot
Assign a port's type at parsed time instead of waiting for the tree to be completed. Because this is now done earlier, we can use the port's type in dsa_port_is_* helpers instead of digging again in topology description. Signed-off-by: Vivien Didelot ---