On Mon, May 18, 2015 at 11:24 PM, Simon Horman
<simon.hor...@netronome.com> wrote:
> The motivation for this is that rocker_port_internal_vlan_id_{get,put} appear
> to only partially implement the transaction model: memory allocation
> and freeing is transactional, but hash and bitmap manipulation is not.
>
> The latter could be fixed, however, as it is not currently exercised
> due to trans always being SWITCHDEV_TRANS_NONE it seems cleaner
> to make rocker_port_internal_vlan_id_get non-transactional.
>
> Found by inspection.
> I do not believe that this change should have any run-time effect.
>
> Fixes: c4f20321d968 ("rocker: support prepare-commit transaction model")
> Signed-off-by: Simon Horman <simon.hor...@netronome.com>This works for now. Once we switch over to using bridge's PVID, we don't need any of this internal vlan stuff anyway, so eventually most (all?) of this internal vlan code goes away. Acked-by: Scott Feldman <sfel...@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
