Re: [PATCH net-next 4/6] drivers: net: xgene-v2: Add base driver

2017-02-26 Thread Iyappan Subramanian
Hi Andrew, On Tue, Jan 31, 2017 at 12:01 PM, Andrew Lunn wrote: >> + phy_mode = device_get_phy_mode(dev); >> + if (phy_mode < 0) { >> + dev_err(dev, "Unable to get phy-connection-type\n"); >> + return phy_mode; >> + } >> +

Re: [PATCH net-next 4/6] drivers: net: xgene-v2: Add base driver

2017-02-26 Thread Iyappan Subramanian
Hi Florian, On Tue, Jan 31, 2017 at 12:31 PM, Florian Fainelli wrote: > On 01/31/2017 11:03 AM, Iyappan Subramanian wrote: >> This patch adds, >> >> - probe, remove, shutdown >> - open, close and stats >> - create and delete ring >> - request and delete

Re: [PATCH net-next 4/6] drivers: net: xgene-v2: Add base driver

2017-01-31 Thread Florian Fainelli
On 01/31/2017 11:03 AM, Iyappan Subramanian wrote: > This patch adds, > > - probe, remove, shutdown > - open, close and stats > - create and delete ring > - request and delete irq > > Signed-off-by: Iyappan Subramanian > Signed-off-by: Keyur Chudgar

Re: [PATCH net-next 4/6] drivers: net: xgene-v2: Add base driver

2017-01-31 Thread Andrew Lunn
> + phy_mode = device_get_phy_mode(dev); > + if (phy_mode < 0) { > + dev_err(dev, "Unable to get phy-connection-type\n"); > + return phy_mode; > + } > + pdata->resources.phy_mode = phy_mode; > + > + if (pdata->resources.phy_mode !=

[PATCH net-next 4/6] drivers: net: xgene-v2: Add base driver

2017-01-31 Thread Iyappan Subramanian
This patch adds, - probe, remove, shutdown - open, close and stats - create and delete ring - request and delete irq Signed-off-by: Iyappan Subramanian Signed-off-by: Keyur Chudgar --- drivers/net/ethernet/apm/xgene-v2/main.c | 459