Re: [PATCH net-next 4/8] net: ethernet: add the Alpine Ethernet driver

2017-11-05 Thread Andrew Lunn
> the problem is that physical MDIO controller actually belongs to one of > the pcie devices and it's not independent interface, as the registers > address belongs to that pcie device, also, a reset to that pcie device > will reset the "shared" mdio controller. What is the implications of

Re: [PATCH net-next 4/8] net: ethernet: add the Alpine Ethernet driver

2017-11-05 Thread BSHARA, Said
> > To: Chocron, Jonathan <jon...@amazon.com> > > > Cc: Antoine Tenart <antoine.ten...@free-electrons.com>; > > > netdev@vger.kernel.org; da...@davemloft.net; linux-arm- > > > ker...@lists.infradead.org; thomas.petazz...@free-electrons.com; > > >

Re: [PATCH net-next 4/8] net: ethernet: add the Alpine Ethernet driver

2017-11-02 Thread Florian Fainelli
.com>; >> netdev@vger.kernel.org; da...@davemloft.net; linux-arm- >> ker...@lists.infradead.org; thomas.petazz...@free-electrons.com; >> a...@arndb.de >> Subject: Re: [PATCH net-next 4/8] net: ethernet: add the Alpine Ethernet >> driver >> >> On Su

RE: [PATCH net-next 4/8] net: ethernet: add the Alpine Ethernet driver

2017-11-02 Thread Chocron, Jonathan
mloft.net; linux-arm- > ker...@lists.infradead.org; thomas.petazz...@free-electrons.com; > a...@arndb.de > Subject: Re: [PATCH net-next 4/8] net: ethernet: add the Alpine Ethernet > driver > > On Sun, Aug 27, 2017 at 01:47:19PM +, Chocron, Jonathan wrote: > > This is a fixed versio

Re: [PATCH net-next 4/8] net: ethernet: add the Alpine Ethernet driver

2017-08-28 Thread Andrew Lunn
On Sun, Aug 27, 2017 at 01:47:19PM +, Chocron, Jonathan wrote: > This is a fixed version of my previous response (using proper indentation and > leaving only the specific questions responded to). Wow, this is old. 3 Feb 2017. I had to go dig into the archive to refresh my memory. > > > +/*

Re: [PATCH net-next 4/8] net: ethernet: add the Alpine Ethernet driver

2017-08-27 Thread Chocron, Jonathan
This is a fixed version of my previous response (using proper indentation and leaving only the specific questions responded to). > > +/* MDIO */ > > +#define AL_ETH_MDIO_C45_DEV_MASK 0x1f > > +#define AL_ETH_MDIO_C45_DEV_SHIFT16 > > +#define AL_ETH_MDIO_C45_REG_MASK 0x > > +

Re: [PATCH net-next 4/8] net: ethernet: add the Alpine Ethernet driver

2017-08-07 Thread Chocron, Jonathan
om; sa...@annapurnalabs.com; ba...@annapurnalabs.com; t...@annapurnalabs.com; thomas.petazz...@free-electrons.com; a...@arndb.de Subject: Re: [PATCH net-next 4/8] net: ethernet: add the Alpine Ethernet driver > +/* MDIO */ > +#define AL_ETH_MDIO_C45_DEV_MASK 0x1f > +#define AL_ETH_MDIO_C45_

Re: [PATCH net-next 4/8] net: ethernet: add the Alpine Ethernet driver

2017-02-03 Thread Andrew Lunn
> +/* MDIO */ > +#define AL_ETH_MDIO_C45_DEV_MASK 0x1f > +#define AL_ETH_MDIO_C45_DEV_SHIFT16 > +#define AL_ETH_MDIO_C45_REG_MASK 0x > + > +static int al_mdio_read(struct mii_bus *bp, int mii_id, int reg) > +{ > + struct al_eth_adapter *adapter = bp->priv; > + u16 value