Re: [PATCH net-next 5/5] ebpf: Add sample ebpf program for SOCKET_SG_FILTER

2018-09-17 Thread Alexei Starovoitov
On Mon, Sep 17, 2018 at 07:23:48PM -0400, Sowmini Varadhan wrote: > On (09/17/18 16:15), Alexei Starovoitov wrote: > > > > if the goal is to add firewall ability to RDS then the patch set > > is going in the wrong direction. > > The goal is to add the ability to process scatterlist directly, >

Re: [PATCH net-next 5/5] ebpf: Add sample ebpf program for SOCKET_SG_FILTER

2018-09-17 Thread Sowmini Varadhan
On (09/17/18 16:15), Alexei Starovoitov wrote: > > if the goal is to add firewall ability to RDS then the patch set > is going in the wrong direction. The goal is to add the ability to process scatterlist directly, just like we process skb's today. Your main objection was that you wanted a test

Re: [PATCH net-next 5/5] ebpf: Add sample ebpf program for SOCKET_SG_FILTER

2018-09-17 Thread Alexei Starovoitov
On Thu, Sep 13, 2018 at 06:10:13AM -0400, Sowmini Varadhan wrote: > On (09/12/18 19:07), Alexei Starovoitov wrote: > > > > I didn't know that. The way I understand your statement that > > this new program type, new sg logic, and all the complexity > > are only applicable to RDMA capable hw and

Re: [PATCH net-next 5/5] ebpf: Add sample ebpf program for SOCKET_SG_FILTER

2018-09-13 Thread Sowmini Varadhan
On (09/12/18 19:07), Alexei Starovoitov wrote: > > I didn't know that. The way I understand your statement that > this new program type, new sg logic, and all the complexity > are only applicable to RDMA capable hw and RDS. I dont know if you have been following the RFC series at all (and

Re: [PATCH net-next 5/5] ebpf: Add sample ebpf program for SOCKET_SG_FILTER

2018-09-12 Thread Alexei Starovoitov
On Wed, Sep 12, 2018 at 08:59:54PM -0400, Sowmini Varadhan wrote: > > On 09/11/2018 09:00 PM, Alexei Starovoitov wrote: > > >please no samples. > > >Add this as proper test to tools/testing/selftests/bpf > > >that reports PASS/FAIL and can be run automatically. > > >samples/bpf is effectively dead

Re: [PATCH net-next 5/5] ebpf: Add sample ebpf program for SOCKET_SG_FILTER

2018-09-12 Thread Sowmini Varadhan
> On 09/11/2018 09:00 PM, Alexei Starovoitov wrote: > >please no samples. > >Add this as proper test to tools/testing/selftests/bpf > >that reports PASS/FAIL and can be run automatically. > >samples/bpf is effectively dead code. Just a second. You do realize that RDS is doing real networking, so

Re: [PATCH net-next 5/5] ebpf: Add sample ebpf program for SOCKET_SG_FILTER

2018-09-12 Thread Tushar Dave
On 09/11/2018 09:00 PM, Alexei Starovoitov wrote: On Tue, Sep 11, 2018 at 09:38:04PM +0200, Tushar Dave wrote: Add a sample program that shows how socksg program is used and attached to socket filter. The kernel sample program deals with struct scatterlist that is passed as bpf context.

Re: [PATCH net-next 5/5] ebpf: Add sample ebpf program for SOCKET_SG_FILTER

2018-09-11 Thread Alexei Starovoitov
On Tue, Sep 11, 2018 at 09:38:04PM +0200, Tushar Dave wrote: > Add a sample program that shows how socksg program is used and attached > to socket filter. The kernel sample program deals with struct > scatterlist that is passed as bpf context. > > When run in server mode, the sample RDS program

[PATCH net-next 5/5] ebpf: Add sample ebpf program for SOCKET_SG_FILTER

2018-09-11 Thread Tushar Dave
Add a sample program that shows how socksg program is used and attached to socket filter. The kernel sample program deals with struct scatterlist that is passed as bpf context. When run in server mode, the sample RDS program opens PF_RDS socket, attaches eBPF program to RDS socket which then uses