Re: [PATCH net-next 5/5] net: aquantia: bump driver version

2018-08-12 Thread Igor Russkikh
>> Hope the above are good enough arguments to keep up version bumps. > > A reasonably successful strategy is to version your out-of-tree driver > with corresponding kernel release versions. Flip the equation. > > E.g. current net-next will become 4.19, so all the features you're > pushing

Re: [PATCH net-next 5/5] net: aquantia: bump driver version

2018-08-09 Thread Jakub Kicinski
On Thu, 9 Aug 2018 13:10:09 +0300, Igor Russkikh wrote: > Hi Andrew, > > Thanks for the review, agreed on all your findings, > we'll address these comments in next version. > > > Driver versions are pretty much useless. Say somebody backports this > > driver into a vendor kernel. Vendor kernels

Re: [PATCH net-next 5/5] net: aquantia: bump driver version

2018-08-09 Thread Igor Russkikh
Hi Andrew, Thanks for the review, agreed on all your findings, we'll address these comments in next version. > Driver versions are pretty much useless. Say somebody backports this > driver into a vendor kernel. Vendor kernels are typically based on an > old kernel, plus thousands of patches. Is

Re: [PATCH net-next 5/5] net: aquantia: bump driver version

2018-08-08 Thread Andrew Lunn
On Wed, Aug 08, 2018 at 01:57:15PM +0300, Igor Russkikh wrote: > Signed-off-by: Igor Russkikh > --- > drivers/net/ethernet/aquantia/atlantic/ver.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/aquantia/atlantic/ver.h >

[PATCH net-next 5/5] net: aquantia: bump driver version

2018-08-08 Thread Igor Russkikh
Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/ver.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/ver.h b/drivers/net/ethernet/aquantia/atlantic/ver.h index 94efc64..b482601 100644 ---

[PATCH net-next 5/5] net: aquantia: bump driver version

2018-05-29 Thread Igor Russkikh
Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/ver.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/ver.h b/drivers/net/ethernet/aquantia/atlantic/ver.h index a445de6..94efc64 100644 ---