RE: [EXT] Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2018-01-03 Thread Stefan Chulski
> Sorry, I find this very confusing. > > It seems we have some people telling me that when there's no PHY described > in DT, we use this link interrupt, and have a functional network interface > (presumably at whatever speed.) I give you couple of examples when we have functional network interfac

Re: [EXT] Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2018-01-03 Thread Marcin Wojtas
Russell, 2018-01-03 18:54 GMT+01:00 Russell King - ARM Linux : > On Wed, Jan 03, 2018 at 05:00:47PM +, Stefan Chulski wrote: >> > > > -Original Message- >> > > > Hi Russell, >> > > > >> > > > Indeed. RGMII MAC behaves same way, although it shouldn't be named >> > > > as 'in- band' to b

Re: [EXT] Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2018-01-03 Thread Russell King - ARM Linux
On Wed, Jan 03, 2018 at 05:00:47PM +, Stefan Chulski wrote: > > > > -Original Message- > > > > Hi Russell, > > > > > > > > Indeed. RGMII MAC behaves same way, although it shouldn't be named > > > > as 'in- band' to be on par with the specifications. Anyway - this > > > > one is rather a

RE: [EXT] Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2018-01-03 Thread Stefan Chulski
> > > -Original Message- > > > Hi Russell, > > > > > > Indeed. RGMII MAC behaves same way, although it shouldn't be named > > > as 'in- band' to be on par with the specifications. Anyway - this > > > one is rather a stub for being able to work with ACPI, so once the > > > MDIO bus works the

Re: [EXT] Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2018-01-01 Thread Russell King - ARM Linux
On Mon, Jan 01, 2018 at 10:35:25AM +, Stefan Chulski wrote: > > > -Original Message- > > Hi Russell, > > > > Indeed. RGMII MAC behaves same way, although it shouldn't be named as 'in- > > band' to be on par with the specifications. Anyway - this one is rather a > > stub for > > being

RE: [EXT] Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2018-01-01 Thread Stefan Chulski
etdev > ; Antoine Tenart electrons.com>; linux-ker...@vger.kernel.org; kis...@ti.com; Nadav Haklai > ; Miquèl Raynal ; > Gregory Clément ; David S. Miller > ; linux-arm-ker...@lists.infradead.org; Sebastian > Hesselbarth > Subject: [EXT] Re: [PATCH net-next 5/6] arm64: dts: marvell:

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2018-01-01 Thread Marcin Wojtas
Hi Russell, 2017-12-30 18:31 GMT+01:00 Russell King - ARM Linux : > Hi Marcin, > > On Sat, Dec 30, 2017 at 05:34:23PM +0100, Marcin Wojtas wrote: >> Yes, I already split the series and will send first one right away. I >> will be followed by MDIO bus / PHY handling proposal, including the >> bits

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-30 Thread Russell King - ARM Linux
Hi Marcin, On Sat, Dec 30, 2017 at 05:34:23PM +0100, Marcin Wojtas wrote: > Yes, I already split the series and will send first one right away. I > will be followed by MDIO bus / PHY handling proposal, including the > bits related to phylink. I'm looking forward to your opinion on that > once sent

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-30 Thread Marcin Wojtas
Hi Russell and Stefan, 2017-12-29 12:38 GMT+01:00 Russell King - ARM Linux : > On Fri, Dec 29, 2017 at 12:12:15PM +0100, Marcin Wojtas wrote: >> Hi Russell, >> >> I see that I misspelled your email address, hence the series remained >> unnoticed: >> https://lkml.org/lkml/2017/12/18/216 >> >> In t

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-29 Thread Antoine Tenart
Hi Russell, On Thu, Dec 28, 2017 at 06:59:21PM +, Russell King - ARM Linux wrote: > On Thu, Dec 28, 2017 at 11:04:16AM +0100, Antoine Tenart wrote: > > > > That's not what I remembered. You had some valid points, and others > > related to PHY modes the driver wasn't supporting before the phyl

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-29 Thread Russell King - ARM Linux
On Fri, Dec 29, 2017 at 12:12:15PM +0100, Marcin Wojtas wrote: > Hi Russell, > > I see that I misspelled your email address, hence the series remained > unnoticed: > https://lkml.org/lkml/2017/12/18/216 > > In terms of the phylink support, I think the most important are: > * 3/8 > https://lkml.o

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-29 Thread Marcin Wojtas
Hi Russell, 2017-12-28 19:46 GMT+01:00 Russell King - ARM Linux : > On Thu, Dec 28, 2017 at 07:27:39PM +0100, Antoine Tenart wrote: >> Hi Florian, >> >> On Thu, Dec 28, 2017 at 07:02:09AM -0800, Florian Fainelli wrote: >> > On 12/28/2017 02:05 AM, Antoine Tenart wrote: >> > > On Thu, Dec 28, 2017

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-28 Thread Russell King - ARM Linux
On Thu, Dec 28, 2017 at 11:04:16AM +0100, Antoine Tenart wrote: > Hi Russell, > > On Wed, Dec 27, 2017 at 11:20:00PM +, Russell King - ARM Linux wrote: > > On Wed, Dec 27, 2017 at 11:42:52PM +0100, Antoine Tenart wrote: > > > > > > What do you suggest to describe this in the dt, to enable a p

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-28 Thread Russell King - ARM Linux
On Thu, Dec 28, 2017 at 07:27:39PM +0100, Antoine Tenart wrote: > Hi Florian, > > On Thu, Dec 28, 2017 at 07:02:09AM -0800, Florian Fainelli wrote: > > On 12/28/2017 02:05 AM, Antoine Tenart wrote: > > > On Thu, Dec 28, 2017 at 08:46:23AM +0100, Andrew Lunn wrote: > > >> On Wed, Dec 27, 2017 at 10

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-28 Thread Antoine Tenart
Hi Florian, On Thu, Dec 28, 2017 at 07:02:09AM -0800, Florian Fainelli wrote: > On 12/28/2017 02:05 AM, Antoine Tenart wrote: > > On Thu, Dec 28, 2017 at 08:46:23AM +0100, Andrew Lunn wrote: > >> On Wed, Dec 27, 2017 at 10:24:01PM +, Russell King - ARM Linux wrote: > >>> On Wed, Dec 27, 2017 a

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-28 Thread Florian Fainelli
On 12/28/2017 02:05 AM, Antoine Tenart wrote: > Hi Andrew, > > On Thu, Dec 28, 2017 at 08:46:23AM +0100, Andrew Lunn wrote: >> On Wed, Dec 27, 2017 at 10:24:01PM +, Russell King - ARM Linux wrote: >>> On Wed, Dec 27, 2017 at 11:14:45PM +0100, Antoine Tenart wrote: +&cps_eth2 { >>

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-28 Thread Antoine Tenart
Hi Andrew, On Thu, Dec 28, 2017 at 08:46:23AM +0100, Andrew Lunn wrote: > On Wed, Dec 27, 2017 at 10:24:01PM +, Russell King - ARM Linux wrote: > > On Wed, Dec 27, 2017 at 11:14:45PM +0100, Antoine Tenart wrote: > > > > > > +&cps_eth2 { > > > + /* CPS Lane 5 */ > > > + status = "okay"; > > >

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-28 Thread Antoine Tenart
Hi Russell, On Wed, Dec 27, 2017 at 11:20:00PM +, Russell King - ARM Linux wrote: > On Wed, Dec 27, 2017 at 11:42:52PM +0100, Antoine Tenart wrote: > > > > What do you suggest to describe this in the dt, to enable a port using > > the current PPv2 driver? > > I don't - I'm merely pointing ou

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-27 Thread Andrew Lunn
On Wed, Dec 27, 2017 at 10:24:01PM +, Russell King - ARM Linux wrote: > On Wed, Dec 27, 2017 at 11:14:45PM +0100, Antoine Tenart wrote: > > This patch enables the fourth network interface on the Marvell > > Macchiatobin. It is configured in the 2500Base-X PHY mode. > > > > Signed-off-by: Antoi

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-27 Thread Russell King - ARM Linux
On Wed, Dec 27, 2017 at 11:42:52PM +0100, Antoine Tenart wrote: > Hi Russell, > > On Wed, Dec 27, 2017 at 10:24:01PM +, Russell King - ARM Linux wrote: > > On Wed, Dec 27, 2017 at 11:14:45PM +0100, Antoine Tenart wrote: > > > > > > +&cps_eth2 { > > > + /* CPS Lane 5 */ > > > + status = "okay

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-27 Thread Antoine Tenart
Hi Russell, On Wed, Dec 27, 2017 at 10:24:01PM +, Russell King - ARM Linux wrote: > On Wed, Dec 27, 2017 at 11:14:45PM +0100, Antoine Tenart wrote: > > > > +&cps_eth2 { > > + /* CPS Lane 5 */ > > + status = "okay"; > > + phy-mode = "2500base-x"; > > + /* Generic PHY, providing serdes

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-27 Thread Russell King - ARM Linux
On Wed, Dec 27, 2017 at 11:14:45PM +0100, Antoine Tenart wrote: > This patch enables the fourth network interface on the Marvell > Macchiatobin. It is configured in the 2500Base-X PHY mode. > > Signed-off-by: Antoine Tenart > --- > arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts | 8 >

[PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-27 Thread Antoine Tenart
This patch enables the fourth network interface on the Marvell Macchiatobin. It is configured in the 2500Base-X PHY mode. Signed-off-by: Antoine Tenart --- arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/marvell/ar