Re: [PATCH net-next V5 4/4] net/sched: Introduce act_tunnel_key

2016-09-06 Thread Hadar Hen Zion
On Tue, Sep 6, 2016 at 5:11 PM, Eric Dumazet wrote: > On Sun, 2016-09-04 at 13:55 +0300, Hadar Hen Zion wrote: >> From: Amir Vadai > > ... > >> +struct tcf_tunnel_key_params { >> + struct rcu_head rcu; >> + int

Re: [PATCH net-next V5 4/4] net/sched: Introduce act_tunnel_key

2016-09-06 Thread Eric Dumazet
On Sun, 2016-09-04 at 13:55 +0300, Hadar Hen Zion wrote: > From: Amir Vadai ... > +struct tcf_tunnel_key_params { > + struct rcu_head rcu; > + int tcft_action; > + int action; > + struct metadata_dst

Re: [PATCH net-next V5 4/4] net/sched: Introduce act_tunnel_key

2016-09-06 Thread Jamal Hadi Salim
On 16-09-06 07:03 AM, Hadar Hen Zion wrote: On Tue, Sep 6, 2016 at 1:49 PM, Jamal Hadi Salim wrote: Please verify by running a test and send a packet or two and verify that stats are incremented (I know it may sound silly to ask but it is important). Already tested that

Re: [PATCH net-next V5 4/4] net/sched: Introduce act_tunnel_key

2016-09-06 Thread Hadar Hen Zion
On Tue, Sep 6, 2016 at 1:49 PM, Jamal Hadi Salim wrote: > On 16-09-04 06:55 AM, Hadar Hen Zion wrote: >> >> From: Amir Vadai >> >> This action could be used before redirecting packets to a shared tunnel >> device, or when redirecting packets arriving from a such

Re: [PATCH net-next V5 4/4] net/sched: Introduce act_tunnel_key

2016-09-06 Thread Jamal Hadi Salim
On 16-09-04 06:55 AM, Hadar Hen Zion wrote: From: Amir Vadai This action could be used before redirecting packets to a shared tunnel device, or when redirecting packets arriving from a such a device. The action will release the metadata created by the tunnel device (decap), or

Re: [PATCH net-next V5 4/4] net/sched: Introduce act_tunnel_key

2016-09-05 Thread Hadar Hen Zion
On Sun, Sep 4, 2016 at 9:19 PM, Rosen, Rami wrote: > Hi, Hadar, > >>For example, the following flower filter will forward all ICMP packets >>destined to 11.11.11.2 >through the shared vxlan device 'vxlan0'. Before >>redirecting, a metadata for the vxlan tunnel >is created

RE: [PATCH net-next V5 4/4] net/sched: Introduce act_tunnel_key

2016-09-04 Thread Rosen, Rami
Hi, Hadar, >For example, the following flower filter will forward all ICMP packets >destined to 11.11.11.2 >through the shared vxlan device 'vxlan0'. Before >redirecting, a metadata for the vxlan tunnel >is created using the tunnel_key >action and it's arguments: Shouldn't it be "tc filter

Re: [PATCH net-next V5 4/4] net/sched: Introduce act_tunnel_key

2016-09-04 Thread kbuild test robot
Hi Amir, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Hadar-Hen-Zion/net-sched-ip-tunnel-metadata-set-release-classify-by-using-TC/20160904-185825 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1

Re: [PATCH net-next V5 4/4] net/sched: Introduce act_tunnel_key

2016-09-04 Thread Shmulik Ladkani
On Sun, 4 Sep 2016 13:55:55 +0300, had...@mellanox.com wrote: > From: Amir Vadai > > This action could be used before redirecting packets to a shared tunnel > device, or when redirecting packets arriving from a such a device. > > The action will release the metadata created by

[PATCH net-next V5 4/4] net/sched: Introduce act_tunnel_key

2016-09-04 Thread Hadar Hen Zion
From: Amir Vadai This action could be used before redirecting packets to a shared tunnel device, or when redirecting packets arriving from a such a device. The action will release the metadata created by the tunnel device (decap), or set the metadata with the specified values for