Re: [PATCH net-next V6 4/4] net/sched: Introduce act_tunnel_key

2016-09-08 Thread Cong Wang
On Thu, Sep 8, 2016 at 6:18 AM, Hadar Hen Zion wrote: > On Wed, Sep 7, 2016 at 7:27 PM, Cong Wang wrote: >> Also, ->cleanup() should be called with RTNL, no need to >> take read lock here. > > RTNL lock isn't taken when cleanup is called.

Re: [PATCH net-next V6 4/4] net/sched: Introduce act_tunnel_key

2016-09-08 Thread Hadar Hen Zion
On Wed, Sep 7, 2016 at 7:27 PM, Cong Wang wrote: > On Wed, Sep 7, 2016 at 1:08 AM, Hadar Hen Zion wrote: >> +struct tcf_tunnel_key_params { >> + struct rcu_head rcu; >> + int tcft_action; >> + int

Re: [PATCH net-next V6 4/4] net/sched: Introduce act_tunnel_key

2016-09-07 Thread Eric Dumazet
On Wed, 2016-09-07 at 09:27 -0700, Cong Wang wrote: > Fix checkpatch.pl (or whatever tool you prefer). I do not use checkpatch.pl. But I know for sure David cares about this ordering. https://lkml.org/lkml/2016/4/24/91 https://patchwork.ozlabs.org/patch/629958/ So feel free to fix

Re: [PATCH net-next V6 4/4] net/sched: Introduce act_tunnel_key

2016-09-07 Thread Cong Wang
On Wed, Sep 7, 2016 at 7:14 AM, Eric Dumazet wrote: > On Wed, 2016-09-07 at 11:08 +0300, Hadar Hen Zion wrote: >> From: Amir Vadai >> > > >> +static int tunnel_key_init(struct net *net, struct nlattr *nla, >> +struct nlattr *est,

Re: [PATCH net-next V6 4/4] net/sched: Introduce act_tunnel_key

2016-09-07 Thread Cong Wang
On Wed, Sep 7, 2016 at 1:08 AM, Hadar Hen Zion wrote: > +struct tcf_tunnel_key_params { > + struct rcu_head rcu; > + int tcft_action; > + int action; > + struct metadata_dst *tcft_enc_metadata; > +};

Re: [PATCH net-next V6 4/4] net/sched: Introduce act_tunnel_key

2016-09-07 Thread Eric Dumazet
On Wed, 2016-09-07 at 11:08 +0300, Hadar Hen Zion wrote: > From: Amir Vadai > > +static int tunnel_key_init(struct net *net, struct nlattr *nla, > +struct nlattr *est, struct tc_action **a, > +int ovr, int bind) > +{ > + struct

[PATCH net-next V6 4/4] net/sched: Introduce act_tunnel_key

2016-09-07 Thread Hadar Hen Zion
From: Amir Vadai This action could be used before redirecting packets to a shared tunnel device, or when redirecting packets arriving from a such a device. The action will release the metadata created by the tunnel device (decap), or set the metadata with the specified values for