Re: [PATCH net-next v16 4/8] netfilter: Add nf_ct_get_tuple_skb callback

2018-05-28 Thread Toke Høiland-Jørgensen
Pablo Neira Ayuso writes: > On Mon, May 28, 2018 at 04:27:46PM +0200, Toke Høiland-Jørgensen wrote: > [...] >> diff --git a/net/netfilter/core.c b/net/netfilter/core.c >> index 0f6b8172fb9a..520565198f0e 100644 >> --- a/net/netfilter/core.c >> +++ b/net/netfilter/core.c >> @@ -572,6 +572,27 @@ vo

Re: [PATCH net-next v16 4/8] netfilter: Add nf_ct_get_tuple_skb callback

2018-05-28 Thread Pablo Neira Ayuso
On Mon, May 28, 2018 at 04:27:46PM +0200, Toke Høiland-Jørgensen wrote: [...] > diff --git a/net/netfilter/core.c b/net/netfilter/core.c > index 0f6b8172fb9a..520565198f0e 100644 > --- a/net/netfilter/core.c > +++ b/net/netfilter/core.c > @@ -572,6 +572,27 @@ void nf_conntrack_destroy(struct nf_con

[PATCH net-next v16 4/8] netfilter: Add nf_ct_get_tuple_skb callback

2018-05-28 Thread Toke Høiland-Jørgensen
This adds a callback to netfilter to extract a conntrack tuple from an skb that works before the _nfct skb field has been initialised (e.g., in an ingress qdisc). The tuple is copied to the caller to avoid issues with reference counting. The callback will return false when conntrack is not loaded,