Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

From: Jiri Pirko Date: Wed, 2 Nov 2016 08:35:02 +0100 > How do you imagine this mode should looks like? Could you draw me some > example? Well, first of all, there is no reason we can't provide a mechanism by which the driver can request and obtain a FIB dump. And it can be

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

Wed, Nov 02, 2016 at 03:35:03PM CET, ro...@cumulusnetworks.com wrote: >On 11/2/16, 6:48 AM, Jiri Pirko wrote: >> Wed, Nov 02, 2016 at 02:29:40PM CET, ro...@cumulusnetworks.com wrote: >>> On Wed, Nov 2, 2016 at 12:20 AM, Jiri Pirko wrote: Wed, Nov 02, 2016 at 03:13:42AM CET,

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

On 11/2/16, 6:48 AM, Jiri Pirko wrote: > Wed, Nov 02, 2016 at 02:29:40PM CET, ro...@cumulusnetworks.com wrote: >> On Wed, Nov 2, 2016 at 12:20 AM, Jiri Pirko wrote: >>> Wed, Nov 02, 2016 at 03:13:42AM CET, ro...@cumulusnetworks.com wrote: >> [snip] >> I understand..but, if

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

Wed, Nov 02, 2016 at 02:29:40PM CET, ro...@cumulusnetworks.com wrote: >On Wed, Nov 2, 2016 at 12:20 AM, Jiri Pirko wrote: >> Wed, Nov 02, 2016 at 03:13:42AM CET, ro...@cumulusnetworks.com wrote: >>> >[snip] > >>>I understand..but, if you are adding some core infrastructure for

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

On Wed, Nov 02, 2016 at 06:29:40AM -0700, Roopa Prabhu wrote: > On Wed, Nov 2, 2016 at 12:20 AM, Jiri Pirko wrote: > > Wed, Nov 02, 2016 at 03:13:42AM CET, ro...@cumulusnetworks.com wrote: > >> > [snip] > > >>I understand..but, if you are adding some core infrastructure for

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

On Wed, Nov 2, 2016 at 12:20 AM, Jiri Pirko wrote: > Wed, Nov 02, 2016 at 03:13:42AM CET, ro...@cumulusnetworks.com wrote: >> [snip] >>I understand..but, if you are adding some core infrastructure for switchdev >>..it cannot be >>based on the number of simple use-cases or data

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

Tue, Nov 01, 2016 at 04:36:50PM CET, da...@davemloft.net wrote: >From: Roopa Prabhu >Date: Tue, 01 Nov 2016 08:14:14 -0700 > >> On 11/1/16, 7:19 AM, Eric Dumazet wrote: >>> On Tue, 2016-11-01 at 00:57 +0200, Ido Schimmel wrote: On Mon, Oct 31, 2016 at 02:24:06PM

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

Wed, Nov 02, 2016 at 03:13:42AM CET, ro...@cumulusnetworks.com wrote: >On 11/1/16, 10:03 AM, Ido Schimmel wrote: >> Hi Roopa, >> >> On Tue, Nov 01, 2016 at 08:14:14AM -0700, Roopa Prabhu wrote: >>> >[snip] >>> I have the same concern as Eric here. >>> >>> I understand why you need it, but can the

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

On 11/1/16, 10:03 AM, Ido Schimmel wrote: > Hi Roopa, > > On Tue, Nov 01, 2016 at 08:14:14AM -0700, Roopa Prabhu wrote: >> [snip] >> I have the same concern as Eric here. >> >> I understand why you need it, but can the driver request for an initial dump >> and that >> dump be made more efficient

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

Hi Roopa, On Tue, Nov 01, 2016 at 08:14:14AM -0700, Roopa Prabhu wrote: > On 11/1/16, 7:19 AM, Eric Dumazet wrote: > > On Tue, 2016-11-01 at 00:57 +0200, Ido Schimmel wrote: > >> On Mon, Oct 31, 2016 at 02:24:06PM -0700, Eric Dumazet wrote: > >>> How well will this work for large FIB tables ? >

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

On Tue, Nov 01, 2016 at 07:19:59AM -0700, Eric Dumazet wrote: > On Tue, 2016-11-01 at 00:57 +0200, Ido Schimmel wrote: > > On Mon, Oct 31, 2016 at 02:24:06PM -0700, Eric Dumazet wrote: > > > > How well will this work for large FIB tables ? > > > > > > Holding rtnl while sending thousands of skb

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

From: Roopa Prabhu Date: Tue, 01 Nov 2016 08:14:14 -0700 > On 11/1/16, 7:19 AM, Eric Dumazet wrote: >> On Tue, 2016-11-01 at 00:57 +0200, Ido Schimmel wrote: >>> On Mon, Oct 31, 2016 at 02:24:06PM -0700, Eric Dumazet wrote: How well will this work for large FIB

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

On 11/1/16, 7:19 AM, Eric Dumazet wrote: > On Tue, 2016-11-01 at 00:57 +0200, Ido Schimmel wrote: >> On Mon, Oct 31, 2016 at 02:24:06PM -0700, Eric Dumazet wrote: >>> How well will this work for large FIB tables ? >>> >>> Holding rtnl while sending thousands of skb will prevent consumers to >>>

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

On Tue, 2016-11-01 at 00:57 +0200, Ido Schimmel wrote: > On Mon, Oct 31, 2016 at 02:24:06PM -0700, Eric Dumazet wrote: > > How well will this work for large FIB tables ? > > > > Holding rtnl while sending thousands of skb will prevent consumers to > > make progress ? > > Can you please clarify

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

On Mon, Oct 31, 2016 at 02:24:06PM -0700, Eric Dumazet wrote: > On Mon, 2016-10-31 at 23:13 +0200, ido...@idosch.org wrote: > > From: Ido Schimmel > > > > When registering a FIB notifier block we should notify the caller of > > already existing FIB entries and rules, as it

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

On Mon, 2016-10-31 at 23:13 +0200, ido...@idosch.org wrote: > From: Ido Schimmel > > When registering a FIB notifier block we should notify the caller of > already existing FIB entries and rules, as it would otherwise have an > incomplete view of the FIB tables. This is

[PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

From: Ido Schimmel When registering a FIB notifier block we should notify the caller of already existing FIB entries and rules, as it would otherwise have an incomplete view of the FIB tables. This is especially important for switchdev drivers that support FIB offloads.