Re: [PATCH net-next v2 0/3] net: dsa: voidify STP setter and FDB/VLAN add ops

2016-04-08 Thread David Miller
From: Vivien Didelot Date: Wed, 6 Apr 2016 11:55:02 -0400 > Neither the DSA layer nor the bridge code (see br_set_state) really care > about eventual errors from STP state setters, so make it void. > > The DSA layer separates the prepare and commit phases

Re: [PATCH net-next v2 0/3] net: dsa: voidify STP setter and FDB/VLAN add ops

2016-04-06 Thread Florian Fainelli
2016-04-06 8:55 GMT-07:00 Vivien Didelot : > Neither the DSA layer nor the bridge code (see br_set_state) really care > about eventual errors from STP state setters, so make it void. > > The DSA layer separates the prepare and commit phases of switchdev in >

Re: [PATCH net-next v2 0/3] net: dsa: voidify STP setter and FDB/VLAN add ops

2016-04-06 Thread Andrew Lunn
On Wed, Apr 06, 2016 at 11:55:02AM -0400, Vivien Didelot wrote: > Neither the DSA layer nor the bridge code (see br_set_state) really care > about eventual errors from STP state setters, so make it void. > > The DSA layer separates the prepare and commit phases of switchdev in > two different

[PATCH net-next v2 0/3] net: dsa: voidify STP setter and FDB/VLAN add ops

2016-04-06 Thread Vivien Didelot
Neither the DSA layer nor the bridge code (see br_set_state) really care about eventual errors from STP state setters, so make it void. The DSA layer separates the prepare and commit phases of switchdev in two different functions. Logical errors must not happen in commit routines, so make them