Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

2016-03-20 Thread Florian Fainelli
On March 17, 2016 1:10:31 PM PDT, Murali Karicheri wrote: >David, > >On 08/18/2015 04:47 PM, David Miller wrote: >> I see some drivers where the foo_debugfs.c file is larger than the >rest >> of the driver. Once people start using it, it's like crack, and they >> dump every

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

2016-03-19 Thread Murali Karicheri
On 03/17/2016 07:18 PM, Florian Fainelli wrote: > On 17/03/16 13:48, Murali Karicheri wrote: >> On 03/17/2016 04:25 PM, Andrew Lunn wrote: >>> On Thu, Mar 17, 2016 at 04:10:31PM -0400, Murali Karicheri wrote: David, On 08/18/2015 04:47 PM, David Miller wrote: > I see some

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

2016-03-19 Thread Andrew Lunn
On Thu, Mar 17, 2016 at 04:10:31PM -0400, Murali Karicheri wrote: > David, > > On 08/18/2015 04:47 PM, David Miller wrote: > > I see some drivers where the foo_debugfs.c file is larger than the rest > > of the driver. Once people start using it, it's like crack, and they > > dump every single

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

2016-03-19 Thread Florian Fainelli
On 17/03/16 13:48, Murali Karicheri wrote: > On 03/17/2016 04:25 PM, Andrew Lunn wrote: >> On Thu, Mar 17, 2016 at 04:10:31PM -0400, Murali Karicheri wrote: >>> David, >>> >>> On 08/18/2015 04:47 PM, David Miller wrote: I see some drivers where the foo_debugfs.c file is larger than the rest

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

2016-03-19 Thread Murali Karicheri
On 03/17/2016 04:25 PM, Andrew Lunn wrote: > On Thu, Mar 17, 2016 at 04:10:31PM -0400, Murali Karicheri wrote: >> David, >> >> On 08/18/2015 04:47 PM, David Miller wrote: >>> I see some drivers where the foo_debugfs.c file is larger than the rest >>> of the driver. Once people start using it,

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

2016-03-19 Thread Ido Schimmel
Thu, Mar 17, 2016 at 10:25:19PM IST, and...@lunn.ch wrote: >On Thu, Mar 17, 2016 at 04:10:31PM -0400, Murali Karicheri wrote: >> David, >> >> On 08/18/2015 04:47 PM, David Miller wrote: >> > I see some drivers where the foo_debugfs.c file is larger than the rest >> > of the driver. Once people

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

2016-03-18 Thread Murali Karicheri
David, On 08/18/2015 04:47 PM, David Miller wrote: > I see some drivers where the foo_debugfs.c file is larger than the rest > of the driver. Once people start using it, it's like crack, and they > dump every single debugging widget they found useful at some point into > there. > > This is not

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

2016-03-18 Thread Murali Karicheri
On 03/17/2016 05:53 PM, Ido Schimmel wrote: > Thu, Mar 17, 2016 at 10:25:19PM IST, and...@lunn.ch wrote: >> On Thu, Mar 17, 2016 at 04:10:31PM -0400, Murali Karicheri wrote: >>> David, >>> >>> On 08/18/2015 04:47 PM, David Miller wrote: I see some drivers where the foo_debugfs.c file is

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

2015-08-19 Thread Scott Feldman
On Tue, Aug 18, 2015 at 1:47 PM, David Miller da...@davemloft.net wrote: From: Scott Feldman sfel...@gmail.com Date: Tue, 18 Aug 2015 13:37:56 -0700 Hi Scott David is not so keen no debugfs stuff. He already NACKed adding more than what is currently in DSA:

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

2015-08-18 Thread Scott Feldman
On Mon, Aug 17, 2015 at 10:55 PM, Jiri Pirko j...@resnulli.us wrote: Tue, Aug 18, 2015 at 12:36:17AM CEST, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com tree /sys/kernel/debug/rocker /sys/kernel/debug/rocker └── 525400123501 ├── fdb_tbl ├── internal_vlan_tbl ├──

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

2015-08-18 Thread Jiri Pirko
Tue, Aug 18, 2015 at 08:14:48AM CEST, sfel...@gmail.com wrote: On Mon, Aug 17, 2015 at 10:55 PM, Jiri Pirko j...@resnulli.us wrote: Tue, Aug 18, 2015 at 12:36:17AM CEST, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com tree /sys/kernel/debug/rocker /sys/kernel/debug/rocker └──

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

2015-08-18 Thread Scott Feldman
On Mon, Aug 17, 2015 at 11:48 PM, Jiri Pirko j...@resnulli.us wrote: Tue, Aug 18, 2015 at 08:14:48AM CEST, sfel...@gmail.com wrote: On Mon, Aug 17, 2015 at 10:55 PM, Jiri Pirko j...@resnulli.us wrote: Tue, Aug 18, 2015 at 12:36:17AM CEST, sfel...@gmail.com wrote: From: Scott Feldman

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

2015-08-18 Thread Jiri Pirko
Tue, Aug 18, 2015 at 09:21:15AM CEST, sfel...@gmail.com wrote: On Mon, Aug 17, 2015 at 11:48 PM, Jiri Pirko j...@resnulli.us wrote: Tue, Aug 18, 2015 at 08:14:48AM CEST, sfel...@gmail.com wrote: On Mon, Aug 17, 2015 at 10:55 PM, Jiri Pirko j...@resnulli.us wrote: Tue, Aug 18, 2015 at 12:36:17AM

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

2015-08-18 Thread Scott Feldman
On Tue, Aug 18, 2015 at 7:01 AM, Andrew Lunn and...@lunn.ch wrote: On Mon, Aug 17, 2015 at 03:36:17PM -0700, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com tree /sys/kernel/debug/rocker /sys/kernel/debug/rocker ? 525400123501 ? fdb_tbl ?

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

2015-08-18 Thread Andrew Lunn
On Tue, Aug 18, 2015 at 10:18:51AM -0700, Scott Feldman wrote: On Tue, Aug 18, 2015 at 7:01 AM, Andrew Lunn and...@lunn.ch wrote: On Mon, Aug 17, 2015 at 03:36:17PM -0700, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com tree /sys/kernel/debug/rocker

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

2015-08-18 Thread David Miller
From: Jiri Pirko j...@resnulli.us Date: Tue, 18 Aug 2015 07:55:55 +0200 Tue, Aug 18, 2015 at 12:36:17AM CEST, sfel...@gmail.com wrote: +static int rocker_probe_debugfs_init(struct rocker *rocker) +{ + char dbg_dir_name[sizeof(rocker-hw.id) * 2 + 1]; + + sprintf(dbg_dir_name, %*phN,

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

2015-08-18 Thread Scott Feldman
On Tue, Aug 18, 2015 at 11:19 AM, Andrew Lunn and...@lunn.ch wrote: On Tue, Aug 18, 2015 at 10:18:51AM -0700, Scott Feldman wrote: On Tue, Aug 18, 2015 at 7:01 AM, Andrew Lunn and...@lunn.ch wrote: On Mon, Aug 17, 2015 at 03:36:17PM -0700, sfel...@gmail.com wrote: From: Scott Feldman

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

2015-08-18 Thread David Miller
From: Scott Feldman sfel...@gmail.com Date: Tue, 18 Aug 2015 13:37:56 -0700 On Tue, Aug 18, 2015 at 11:19 AM, Andrew Lunn and...@lunn.ch wrote: On Tue, Aug 18, 2015 at 10:18:51AM -0700, Scott Feldman wrote: On Tue, Aug 18, 2015 at 7:01 AM, Andrew Lunn and...@lunn.ch wrote: On Mon, Aug 17,

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

2015-08-18 Thread Andrew Lunn
On Mon, Aug 17, 2015 at 03:36:17PM -0700, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com tree /sys/kernel/debug/rocker /sys/kernel/debug/rocker ? 525400123501 ? fdb_tbl ? internal_vlan_tbl ? neigh_tbl ?

[PATCH net-next v3] rocker: add debugfs support to dump internal tables

2015-08-17 Thread sfeldma
From: Scott Feldman sfel...@gmail.com tree /sys/kernel/debug/rocker /sys/kernel/debug/rocker └── 525400123501 ├── fdb_tbl ├── internal_vlan_tbl ├── neigh_tbl ├── of_dpa_flow_tbl └── of_dpa_group_tbl 1 directory, 5 files cat

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

2015-08-17 Thread Jiri Pirko
Tue, Aug 18, 2015 at 12:36:17AM CEST, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com tree /sys/kernel/debug/rocker /sys/kernel/debug/rocker └── 525400123501 ├── fdb_tbl ├── internal_vlan_tbl ├── neigh_tbl ├── of_dpa_flow_tbl └── of_dpa_group_tbl 1