Re: [PATCH net-next v3 04/11] bpf: Use bpf_load_program() from the library

2017-02-08 Thread Mickaël Salaün
On 08/02/2017 20:46, Arnaldo Carvalho de Melo wrote: > Em Tue, Feb 07, 2017 at 03:17:43PM -0800, Alexei Starovoitov escreveu: >> On 2/7/17 1:44 PM, Mickaël Salaün wrote: >>> - union bpf_attr attr; >>> + union bpf_attr attr = {}; >>> >>> - bzero(, sizeof(attr)); >> >> I think somebody

Re: [PATCH net-next v3 04/11] bpf: Use bpf_load_program() from the library

2017-02-08 Thread Arnaldo Carvalho de Melo
Em Tue, Feb 07, 2017 at 03:17:43PM -0800, Alexei Starovoitov escreveu: > On 2/7/17 1:44 PM, Mickaël Salaün wrote: > >-union bpf_attr attr; > >+union bpf_attr attr = {}; > > > >-bzero(, sizeof(attr)); > > I think somebody mentioned that there are compilers out there > that don't do it

Re: [PATCH net-next v3 04/11] bpf: Use bpf_load_program() from the library

2017-02-08 Thread Arnaldo Carvalho de Melo
Em Tue, Feb 07, 2017 at 03:17:43PM -0800, Alexei Starovoitov escreveu: > On 2/7/17 1:44 PM, Mickaël Salaün wrote: > >-union bpf_attr attr; > >+union bpf_attr attr = {}; > > > >-bzero(, sizeof(attr)); > I think somebody mentioned that there are compilers out there > that don't do it

Re: [PATCH net-next v3 04/11] bpf: Use bpf_load_program() from the library

2017-02-07 Thread Alexei Starovoitov
On 2/7/17 1:44 PM, Mickaël Salaün wrote: - union bpf_attr attr; + union bpf_attr attr = {}; - bzero(, sizeof(attr)); I think somebody mentioned that there are compilers out there that don't do it correctly, hence it was done with explicit bzero. Arnaldo, Wang, do you

[PATCH net-next v3 04/11] bpf: Use bpf_load_program() from the library

2017-02-07 Thread Mickaël Salaün
Replace bpf_prog_load() with bpf_load_program() calls. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Shuah Khan --- tools/lib/bpf/bpf.c | 9 -