Re: [PATCH net-next v3 1/8] gtp: add documentation

2017-02-22 Thread Andreas Schultz
Hi Harald, - On Feb 22, 2017, at 9:36 AM, laforge lafo...@gnumonks.org wrote: > Hi Andreas, > > thanks for your feedback. > > On Mon, Feb 20, 2017 at 06:28:07PM +0100, Andreas Schultz wrote: >> > Are you absolutely sure about this? >> >> Yes. It took me a while to realize this. The crux

Re: [PATCH net-next v3 1/8] gtp: add documentation

2017-02-22 Thread Harald Welte
Hi Andreas, thanks for your feedback. On Mon, Feb 20, 2017 at 06:28:07PM +0100, Andreas Schultz wrote: > > Are you absolutely sure about this? > > Yes. It took me a while to realize this. The crux is this statement in TS > 29.060, > Section 7.3.1: > > > The SGSN shall include an SGSN Address

Re: [PATCH net-next v3 1/8] gtp: add documentation

2017-02-20 Thread Neels Hofmeyr
On Mon, Feb 20, 2017 at 06:28:07PM +0100, Andreas Schultz wrote: > >> +A specific tunnel is only defined by the destination entity. Since the > >> +destination port is constant, only the destination IP and TEID define > >> +a tunnel. The source IP and Port have no meaning for the tunnel. > > > >

Re: [PATCH net-next v3 1/8] gtp: add documentation

2017-02-20 Thread Andreas Schultz
Hi, - On Feb 20, 2017, at 5:15 PM, laforge lafo...@gnumonks.org wrote: > Hi Andreas, > > this is not really about the documentation, but it still makes sense to > discuss here as the issue is best described: > > On Mon, Feb 13, 2017 at 04:36:17PM +0100, Andreas Schultz wrote: >> +Local

Re: [PATCH net-next v3 1/8] gtp: add documentation

2017-02-20 Thread Harald Welte
Hi Andreas, this is not really about the documentation, but it still makes sense to discuss here as the issue is best described: On Mon, Feb 13, 2017 at 04:36:17PM +0100, Andreas Schultz wrote: > +Local GTP-U entity and tunnel identification > + > + >

[PATCH net-next v3 1/8] gtp: add documentation

2017-02-13 Thread Andreas Schultz
The GTP-U implementation in not only driven by 3GPP TS 29.281, but also by the requirements of the 3GPP network entities that use it. This document tries to explain and clarify some design decision and their origins. Signed-off-by: Andreas Schultz ---