Re: [PATCH net-next v5] net: ipv6: Make address flushing on ifdown optional

2015-10-14 Thread David Ahern
On 10/14/15 3:34 AM, Hannes Frederic Sowa wrote: Hello, On Wed, Oct 14, 2015, at 03:45, David Miller wrote: From: David Ahern Date: Mon, 12 Oct 2015 09:33:07 -0700 Currently, all ipv6 addresses are flushed when the interface is configured down, including global,

Re: [PATCH net-next v5] net: ipv6: Make address flushing on ifdown optional

2015-10-14 Thread Hannes Frederic Sowa
Hello, On Wed, Oct 14, 2015, at 03:45, David Miller wrote: > From: David Ahern > Date: Mon, 12 Oct 2015 09:33:07 -0700 > > > Currently, all ipv6 addresses are flushed when the interface is configured > > down, including global, static addresses: > ... > > Add a new

Re: [PATCH net-next v5] net: ipv6: Make address flushing on ifdown optional

2015-10-14 Thread Nicolas Dichtel
Le 14/10/2015 11:34, Hannes Frederic Sowa a écrit : [sni] This sysctl is on my list to be enabled soon by default by any systemd based distribution. For that reason, could you maybe remove all the I'm not sure to understand why we add a sysctl then. Or at least, why the linux default value is

Re: [PATCH net-next v5] net: ipv6: Make address flushing on ifdown optional

2015-10-14 Thread Hannes Frederic Sowa
On Wed, Oct 14, 2015, at 12:08, Nicolas Dichtel wrote: > Le 14/10/2015 11:34, Hannes Frederic Sowa a écrit : > [sni] > > This sysctl is on my list to be enabled soon by default by any systemd > > based distribution. For that reason, could you maybe remove all the > I'm not sure to understand why

Re: [PATCH net-next v5] net: ipv6: Make address flushing on ifdown optional

2015-10-14 Thread David Miller
From: David Ahern Date: Wed, 14 Oct 2015 10:09:59 -0600 > This latest patch makes IPv6 static addresses on par with IPv4, > including error paths. I don't agree with ipv4's behavior... and just because ipv4 does something poorly doesn't mean we get a free pass to

Re: [PATCH net-next v5] net: ipv6: Make address flushing on ifdown optional

2015-10-14 Thread David Miller
From: Hannes Frederic Sowa Date: Wed, 14 Oct 2015 13:03:41 +0200 > On Wed, Oct 14, 2015, at 12:08, Nicolas Dichtel wrote: >> Le 14/10/2015 11:34, Hannes Frederic Sowa a écrit : >> [sni] >> > This sysctl is on my list to be enabled soon by default by any systemd >> >

Re: [PATCH net-next v5] net: ipv6: Make address flushing on ifdown optional

2015-10-14 Thread Hannes Frederic Sowa
On Wed, Oct 14, 2015, at 14:18, David Miller wrote: > From: Hannes Frederic Sowa > Date: Wed, 14 Oct 2015 13:03:41 +0200 > > The difference is that people upgrade (in case of fedora they get a > > .rpmnew file) or install a distribution and don't wonder or have > >

Re: [PATCH net-next v5] net: ipv6: Make address flushing on ifdown optional

2015-10-14 Thread David Miller
From: Hannes Frederic Sowa Date: Wed, 14 Oct 2015 14:14:05 +0200 > I can bring up the rp_filter setting, too. It currently gets > unconditional set to strict mode in systemd on all interfaces. Sigh... > The question is, if we should care about people enabling

Re: [PATCH net-next v5] net: ipv6: Make address flushing on ifdown optional

2015-10-14 Thread David Ahern
On 10/14/15 7:06 PM, David Miller wrote: From: David Ahern Date: Wed, 14 Oct 2015 10:09:59 -0600 This latest patch makes IPv6 static addresses on par with IPv4, including error paths. I don't agree with ipv4's behavior... and just because ipv4 does something poorly

Re: [PATCH net-next v5] net: ipv6: Make address flushing on ifdown optional

2015-10-13 Thread David Miller
From: David Ahern Date: Mon, 12 Oct 2015 09:33:07 -0700 > Currently, all ipv6 addresses are flushed when the interface is configured > down, including global, static addresses: ... > Add a new sysctl to make this behavior optional. The new setting defaults to > flush

[PATCH net-next v5] net: ipv6: Make address flushing on ifdown optional

2015-10-12 Thread David Ahern
Currently, all ipv6 addresses are flushed when the interface is configured down, including global, static addresses: $ ip -6 addr add dev eth1 2000:11:1:1::1/64 $ ip addr show dev eth1 3: eth1: mtu 1500 qdisc noop state DOWN group default qlen 1000