Re: [PATCH net 1/1] net sched actions: fix GETing actions

2016-09-11 Thread Cong Wang
On Sun, Sep 11, 2016 at 9:30 AM, Jamal Hadi Salim wrote: > > What do you want the commit message to say? It shows an example because > the functionality broke. I expect it to explain why we need to increase that refcnt for GET and how we missed it. Also need to find a right

Re: [PATCH net 1/1] net sched actions: fix GETing actions

2016-09-11 Thread Jamal Hadi Salim
On 16-09-08 01:12 PM, Cong Wang wrote: +} + static int tca_action_gd(struct net *net, struct nlattr *nla, struct nlmsghdr *n, u32 portid, int event) @@ -883,6 +894,7 @@ tca_action_gd(struct net *net, struct nlattr *nla, struct nlmsghdr *n, goto err;

Re: [PATCH net 1/1] net sched actions: fix GETing actions

2016-09-08 Thread Cong Wang
On Thu, Sep 8, 2016 at 5:12 AM, Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > Example of what broke: > ...add a gact action to drop > sudo $TC actions add action drop index 10 > ...now retrieve it, looks good > sudo $TC actions get action gact index

[PATCH net 1/1] net sched actions: fix GETing actions

2016-09-08 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Example of what broke: ...add a gact action to drop sudo $TC actions add action drop index 10 ...now retrieve it, looks good sudo $TC actions get action gact index 10 ...retrieve it again and find it is gone! sudo $TC actions get action gact index 10