Re: [PATCH net 1/2] rhashtable: Fix rhltable duplicates insertion

2018-03-04 Thread Herbert Xu
On Sun, Mar 04, 2018 at 02:34:26PM +0200, Paul Blakey wrote: > When inserting duplicate objects (those with the same key), > current rhashtable implementation messes up the chain pointers by > updating the bucket pointer instead of prev next pointer to the > newly inserted node. This causes

Re: [PATCH net 1/2] rhashtable: Fix rhltable duplicates insertion

2018-03-04 Thread Paul Blakey
On 04/03/2018 14:57, Herbert Xu wrote: On Sun, Mar 04, 2018 at 02:34:26PM +0200, Paul Blakey wrote: When inserting duplicate objects (those with the same key), current rhashtable implementation messes up the chain pointers by updating the bucket pointer instead of prev next pointer to the

Re: [PATCH net 1/2] rhashtable: Fix rhltable duplicates insertion

2018-03-04 Thread Herbert Xu
On Sun, Mar 04, 2018 at 02:34:26PM +0200, Paul Blakey wrote: > When inserting duplicate objects (those with the same key), > current rhashtable implementation messes up the chain pointers by > updating the bucket pointer instead of prev next pointer to the > newly inserted node. This causes

[PATCH net 1/2] rhashtable: Fix rhltable duplicates insertion

2018-03-04 Thread Paul Blakey
When inserting duplicate objects (those with the same key), current rhashtable implementation messes up the chain pointers by updating the bucket pointer instead of prev next pointer to the newly inserted node. This causes missing elements on removal and travesal. Fix that by properly updating