Re: [PATCH net 1/3] net: bql: add netdev_tx_sent_queue_more() helper

2018-10-31 Thread Eric Dumazet
On Wed, Oct 31, 2018 at 4:30 AM Tariq Toukan wrote: > > > > On 30/10/2018 1:25 AM, Eric Dumazet wrote: > > When qdisc_run() tries to use BQL budget to bulk-dequeue a batch > > of packets, GSO can later transform this list in another list > > of skbs, and each skb is sent to device

Re: [PATCH net 1/3] net: bql: add netdev_tx_sent_queue_more() helper

2018-10-31 Thread Tariq Toukan
On 30/10/2018 1:25 AM, Eric Dumazet wrote: > When qdisc_run() tries to use BQL budget to bulk-dequeue a batch > of packets, GSO can later transform this list in another list > of skbs, and each skb is sent to device ndo_start_xmit(), > one at a time, with skb->xmit_more being set to one but >

[PATCH net 1/3] net: bql: add netdev_tx_sent_queue_more() helper

2018-10-29 Thread Eric Dumazet
When qdisc_run() tries to use BQL budget to bulk-dequeue a batch of packets, GSO can later transform this list in another list of skbs, and each skb is sent to device ndo_start_xmit(), one at a time, with skb->xmit_more being set to one but for last skb. Problem is that very often, BQL limit is