Re: [PATCH net 10/11] sfc-falcon: remove ndo_poll_controller

2018-09-28 Thread Bert Kenward
On 27/09/18 17:32, Eric Dumazet wrote: > As diagnosed by Song Liu, ndo_poll_controller() can > be very dangerous on loaded hosts, since the cpu > calling ndo_poll_controller() might steal all NAPI > contexts (for all RX/TX queues of the NIC). This capture > can last for unlimited amount of time,

[PATCH net 10/11] sfc-falcon: remove ndo_poll_controller

2018-09-27 Thread Eric Dumazet
As diagnosed by Song Liu, ndo_poll_controller() can be very dangerous on loaded hosts, since the cpu calling ndo_poll_controller() might steal all NAPI contexts (for all RX/TX queues of the NIC). This capture can last for unlimited amount of time, since one cpu is generally not able to drain all