Re: [PATCH net 2/3] sctp: hold transport before we access t->asoc in sctp proc

2016-01-21 Thread Marcelo Ricardo Leitner
On Fri, Jan 22, 2016 at 01:49:08AM +0800, Xin Long wrote: > Previously, before rhashtable, /proc assoc listing was done by > read-locking the entire hash entry and dumping all assocs at once, so we > were sure that the assoc wasn't freed because it wouldn't be possible to > remove it from the hash

[PATCH net 2/3] sctp: hold transport before we access t->asoc in sctp proc

2016-01-21 Thread Xin Long
Previously, before rhashtable, /proc assoc listing was done by read-locking the entire hash entry and dumping all assocs at once, so we were sure that the assoc wasn't freed because it wouldn't be possible to remove it from the hash meanwhile. Now we use rhashtable to list transports, and dump

Re: [PATCH net 2/3] sctp: hold transport before we access t->asoc in sctp proc

2016-01-21 Thread Eric Dumazet
On Thu, 2016-01-21 at 17:37 -0200, Marcelo Ricardo Leitner wrote: > On Thu, Jan 21, 2016 at 11:27:36AM -0800, Eric Dumazet wrote: > > On Fri, 2016-01-22 at 01:49 +0800, Xin Long wrote: > > > Previously, before rhashtable, /proc assoc listing was done by > > > read-locking the entire hash entry and

Re: [PATCH net 2/3] sctp: hold transport before we access t->asoc in sctp proc

2016-01-21 Thread Marcelo Ricardo Leitner
On Thu, Jan 21, 2016 at 11:57:16AM -0800, Eric Dumazet wrote: > On Thu, 2016-01-21 at 17:37 -0200, Marcelo Ricardo Leitner wrote: > > On Thu, Jan 21, 2016 at 11:27:36AM -0800, Eric Dumazet wrote: > > > On Fri, 2016-01-22 at 01:49 +0800, Xin Long wrote: > > > > Previously, before rhashtable, /proc

Re: [PATCH net 2/3] sctp: hold transport before we access t->asoc in sctp proc

2016-01-21 Thread Marcelo Ricardo Leitner
On Thu, Jan 21, 2016 at 11:27:36AM -0800, Eric Dumazet wrote: > On Fri, 2016-01-22 at 01:49 +0800, Xin Long wrote: > > Previously, before rhashtable, /proc assoc listing was done by > > read-locking the entire hash entry and dumping all assocs at once, so we > > were sure that the assoc wasn't

Re: [PATCH net 2/3] sctp: hold transport before we access t->asoc in sctp proc

2016-01-21 Thread Eric Dumazet
On Fri, 2016-01-22 at 01:49 +0800, Xin Long wrote: > Previously, before rhashtable, /proc assoc listing was done by > read-locking the entire hash entry and dumping all assocs at once, so we > were sure that the assoc wasn't freed because it wouldn't be possible to > remove it from the hash