Thanks for the comments, Yunsheng,
>>
>> +static int aq_nic_update_link_status(struct aq_nic_s *self)
>> +{
>> +int err = self->aq_hw_ops.hw_get_link_status(self->aq_hw);
>> +
>> +if (err < 0)
>> +return -1;
> why not just return err?
Agreed, that could be improved.
>> +
Hi, Igor
On 2017/9/21 18:53, Igor Russkikh wrote:
> Driver did a poor job in managing its Tx queues: Sometimes it could stop
> tx queues due to link down condition in aq_nic_xmit - but never waked up
> them. That led to Tx path total suspend.
> This patch fixes this and improves generic queue
Driver did a poor job in managing its Tx queues: Sometimes it could stop
tx queues due to link down condition in aq_nic_xmit - but never waked up
them. That led to Tx path total suspend.
This patch fixes this and improves generic queue management:
- introduces queue restart counter
- uses generic
