Re: [PATCH net 3/3] bonding: process the err returned by dev_set_allmulti properly in bond_enslave

2018-03-26 Thread Andy Gospodarek
On Mon, Mar 26, 2018 at 01:16:47AM +0800, Xin Long wrote: > When dev_set_promiscuity(1) succeeds but dev_set_allmulti(1) fails, > dev_set_promiscuity(-1) should be done before going to the err path. > Otherwise, dev->promiscuity will leak. > > Fixes: 7e1a1ac1fbaa ("bonding: Check return of dev_set

[PATCH net 3/3] bonding: process the err returned by dev_set_allmulti properly in bond_enslave

2018-03-25 Thread Xin Long
When dev_set_promiscuity(1) succeeds but dev_set_allmulti(1) fails, dev_set_promiscuity(-1) should be done before going to the err path. Otherwise, dev->promiscuity will leak. Fixes: 7e1a1ac1fbaa ("bonding: Check return of dev_set_promiscuity/allmulti") Signed-off-by: Xin Long --- drivers/net/bo