Re: [PATCH net 3/3] eet: ena: invoke netif_carrier_off() only after netdev registered

2018-01-02 Thread Belgazal, Netanel
Right. I’ll remove this patch. On 1/2/18, 9:08 PM, "David Miller" wrote: From: Date: Thu, 28 Dec 2017 21:30:20 + > From: Netanel Belgazal > > netif_carrier_off() should be called only after register

Re: [PATCH net 3/3] eet: ena: invoke netif_carrier_off() only after netdev registered

2018-01-02 Thread David Miller
From: Date: Thu, 28 Dec 2017 21:30:20 + > From: Netanel Belgazal > > netif_carrier_off() should be called only after register netdev. > Move the function's call after the registration. > > Signed-off-by: Netanel Belgazal > --- >

Re: [PATCH net 3/3] eet: ena: invoke netif_carrier_off() only after netdev registered

2017-12-29 Thread Jakub Kicinski
On Fri, 29 Dec 2017 08:00:33 +, Belgazal, Netanel wrote: > Yes, I mean in my driver. > netif_carrier_off() have no effect when netdev is uninitialized. Please look at the implementation again, test_*and_set*_bit(). > So I must call it after register_netdev(). Is there a user-visible problem

Re: [PATCH net 3/3] eet: ena: invoke netif_carrier_off() only after netdev registered

2017-12-29 Thread Belgazal, Netanel
Yes, I mean in my driver. netif_carrier_off() have no effect when netdev is uninitialized. So I must call it after register_netdev(). On 12/29/17, 9:46 AM, "Jakub Kicinski" wrote: By "should" you mean in your driver, right? I think calling netif_carrier_off() on an

Re: [PATCH net 3/3] eet: ena: invoke netif_carrier_off() only after netdev registered

2017-12-28 Thread Jakub Kicinski
On Thu, 28 Dec 2017 21:30:20 +, neta...@amazon.com wrote: > From: Netanel Belgazal > > netif_carrier_off() should be called only after register netdev. > Move the function's call after the registration. By "should" you mean in your driver, right? I think calling

[PATCH net 3/3] eet: ena: invoke netif_carrier_off() only after netdev registered

2017-12-28 Thread netanel
From: Netanel Belgazal netif_carrier_off() should be called only after register netdev. Move the function's call after the registration. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 4 ++-- 1 file changed, 2