Re: [PATCH net 4/5] tcp: prevent bogus undos when SACK is not enabled

2018-03-13 Thread Ilpo Järvinen
On Fri, 9 Mar 2018, David Miller wrote: > From: Ilpo Järvinen > Date: Fri, 9 Mar 2018 16:11:47 +0200 (EET) > > > Unfortunately I don't have now permission to publish the time-seq > > graph about it but I've tried to improve the changelog messages so > > that you can better understand under which

Re: [PATCH net 4/5] tcp: prevent bogus undos when SACK is not enabled

2018-03-09 Thread Ilpo Järvinen
On Fri, 9 Mar 2018, David Miller wrote: > From: Ilpo Järvinen > Date: Fri, 9 Mar 2018 16:11:47 +0200 (EET) > > > Unfortunately I don't have now permission to publish the time-seq > > graph about it but I've tried to improve the changelog messages so > > that you can better understand under which

Re: [PATCH net 4/5] tcp: prevent bogus undos when SACK is not enabled

2018-03-09 Thread David Miller
From: Eric Dumazet Date: Fri, 9 Mar 2018 06:32:21 -0800 > We have the goal of updating packetdrill and publish soon our > regression suite (about 1500 TCP tests) > > CC Willem who is working on that. Excellent news!

Re: [PATCH net 4/5] tcp: prevent bogus undos when SACK is not enabled

2018-03-09 Thread David Miller
From: Ilpo Järvinen Date: Fri, 9 Mar 2018 16:11:47 +0200 (EET) > Unfortunately I don't have now permission to publish the time-seq > graph about it but I've tried to improve the changelog messages so > that you can better understand under which conditions the problem > occurs. It is indeed extre

Re: [PATCH net 4/5] tcp: prevent bogus undos when SACK is not enabled

2018-03-09 Thread Eric Dumazet
On 03/09/2018 06:11 AM, Ilpo Järvinen wrote: On Wed, 7 Mar 2018, Yuchung Cheng wrote: On Wed, Mar 7, 2018 at 12:19 PM, Neal Cardwell wrote: On Wed, Mar 7, 2018 at 7:59 AM, Ilpo Järvinen wrote: A bogus undo may/will trigger when the loss recovery state is kept until snd_una is above high_

Re: [PATCH net 4/5] tcp: prevent bogus undos when SACK is not enabled

2018-03-09 Thread Ilpo Järvinen
On Wed, 7 Mar 2018, Yuchung Cheng wrote: > On Wed, Mar 7, 2018 at 12:19 PM, Neal Cardwell wrote: > > > > On Wed, Mar 7, 2018 at 7:59 AM, Ilpo Järvinen > > wrote: > > > A bogus undo may/will trigger when the loss recovery state is > > > kept until snd_una is above high_seq. If tcp_any_retrans_do

Re: [PATCH net 4/5] tcp: prevent bogus undos when SACK is not enabled

2018-03-07 Thread Yuchung Cheng
On Wed, Mar 7, 2018 at 12:19 PM, Neal Cardwell wrote: > > On Wed, Mar 7, 2018 at 7:59 AM, Ilpo Järvinen > wrote: > > A bogus undo may/will trigger when the loss recovery state is > > kept until snd_una is above high_seq. If tcp_any_retrans_done > > is zero, retrans_stamp is cleared in this trans

Re: [PATCH net 4/5] tcp: prevent bogus undos when SACK is not enabled

2018-03-07 Thread Neal Cardwell
On Wed, Mar 7, 2018 at 7:59 AM, Ilpo Järvinen wrote: > A bogus undo may/will trigger when the loss recovery state is > kept until snd_una is above high_seq. If tcp_any_retrans_done > is zero, retrans_stamp is cleared in this transient state. On > the next ACK, tcp_try_undo_recovery again executes

[PATCH net 4/5] tcp: prevent bogus undos when SACK is not enabled

2018-03-07 Thread Ilpo Järvinen
A bogus undo may/will trigger when the loss recovery state is kept until snd_una is above high_seq. If tcp_any_retrans_done is zero, retrans_stamp is cleared in this transient state. On the next ACK, tcp_try_undo_recovery again executes and tcp_may_undo will always return true because tcp_packet_de