From: Shaohua Li <s...@fb.com>

According to David Miller, the rotation doesn't really help avoid
security problem, so delte it.

Suggested-by: David Miller <da...@davemloft.net>
Signed-off-by: Shaohua Li <s...@fb.com>
---
 include/net/ipv6.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/include/net/ipv6.h b/include/net/ipv6.h
index 6eac5cf..7548367 100644
--- a/include/net/ipv6.h
+++ b/include/net/ipv6.h
@@ -790,12 +790,6 @@ static inline __be32 ip6_make_flowlabel(struct net *net, 
struct sk_buff *skb,
 
        hash = skb_get_hash_flowi6(skb, fl6);
 
-       /* Since this is being sent on the wire obfuscate hash a bit
-        * to minimize possbility that any useful information to an
-        * attacker is leaked. Only lower 20 bits are relevant.
-        */
-       rol32(hash, 16);
-
        flowlabel = (__force __be32)hash & IPV6_FLOWLABEL_MASK;
 
        if (net->ipv6.sysctl.flowlabel_state_ranges)
-- 
2.9.3

Reply via email to