Re: [PATCH net v2] net: Do not hold the reference for the same sk_rx_dst

2017-03-20 Thread Kaiwen Xu
On Sun, Mar 19, 2017 at 09:09:38PM -0700, Cong Wang wrote: > On Sat, Mar 18, 2017 at 9:03 PM, Kaiwen Xu wrote: > > On Sat, Mar 18, 2017 at 08:49:43PM -0700, Cong Wang wrote: > >> On Sat, Mar 18, 2017 at 6:48 PM, Kevin Xu wrote: > >> > In some rare cases,

Re: [PATCH net v2] net: Do not hold the reference for the same sk_rx_dst

2017-03-19 Thread Cong Wang
On Sat, Mar 18, 2017 at 9:03 PM, Kaiwen Xu wrote: > On Sat, Mar 18, 2017 at 08:49:43PM -0700, Cong Wang wrote: >> On Sat, Mar 18, 2017 at 6:48 PM, Kevin Xu wrote: >> > In some rare cases, inet_sk_rx_dst_set() may be called multiple times >> > on the same

Re: [PATCH net v2] net: Do not hold the reference for the same sk_rx_dst

2017-03-18 Thread Kaiwen Xu
On Sat, Mar 18, 2017 at 08:49:43PM -0700, Cong Wang wrote: > On Sat, Mar 18, 2017 at 6:48 PM, Kevin Xu wrote: > > In some rare cases, inet_sk_rx_dst_set() may be called multiple times > > on the same dst, causing double refcounting. Eventually, it > > prevents net_device to be

Re: [PATCH net v2] net: Do not hold the reference for the same sk_rx_dst

2017-03-18 Thread Cong Wang
On Sat, Mar 18, 2017 at 6:48 PM, Kevin Xu wrote: > In some rare cases, inet_sk_rx_dst_set() may be called multiple times > on the same dst, causing double refcounting. Eventually, it > prevents net_device to be destroyed. The bug manifested as > > unregister_netdevice: waiting

[PATCH net v2] net: Do not hold the reference for the same sk_rx_dst

2017-03-18 Thread Kevin Xu
In some rare cases, inet_sk_rx_dst_set() may be called multiple times on the same dst, causing double refcounting. Eventually, it prevents net_device to be destroyed. The bug manifested as unregister_netdevice: waiting for lo to become free. Usage count = 1 in the kernel log, preventing new