[PATCH net v2 3/4] ipv6: no CHECKSUM_PARTIAL on MSG_MORE corked sockets

2015-10-27 Thread Hannes Frederic Sowa
We cannot reliable calculate packet size on MSG_MORE corked sockets and thus cannot decide if they are going to be fragmented later on, so better not use CHECKSUM_PARTIAL in the first place. The IPv6 code also intended to protect and not use CHECKSUM_PARTIAL in the existence of IPv6 extension

Re: [PATCH net v2 3/4] ipv6: no CHECKSUM_PARTIAL on MSG_MORE corked sockets

2015-10-27 Thread Tom Herbert
On Tue, Oct 27, 2015 at 8:02 AM, Hannes Frederic Sowa wrote: > We cannot reliable calculate packet size on MSG_MORE corked sockets > and thus cannot decide if they are going to be fragmented later on, > so better not use CHECKSUM_PARTIAL in the first place. > > The

Re: [PATCH net v2 3/4] ipv6: no CHECKSUM_PARTIAL on MSG_MORE corked sockets

2015-10-27 Thread Tom Herbert
On Tue, Oct 27, 2015 at 11:29 AM, Hannes Frederic Sowa wrote: > On Tue, Oct 27, 2015, at 18:32, Tom Herbert wrote: >> On Tue, Oct 27, 2015 at 9:44 AM, Hannes Frederic Sowa >> wrote: >> > >> > >> > On Tue, Oct 27, 2015, at 17:36, Tom Herbert

Re: [PATCH net v2 3/4] ipv6: no CHECKSUM_PARTIAL on MSG_MORE corked sockets

2015-10-27 Thread Tom Herbert
On Tue, Oct 27, 2015 at 9:44 AM, Hannes Frederic Sowa wrote: > > > On Tue, Oct 27, 2015, at 17:36, Tom Herbert wrote:> > - if > (cork->length + length > maxnonfragsize - headersize) { >> > + if (cork->length + length > maxnonfragsize - headersize) {

Re: [PATCH net v2 3/4] ipv6: no CHECKSUM_PARTIAL on MSG_MORE corked sockets

2015-10-27 Thread Hannes Frederic Sowa
On Tue, Oct 27, 2015, at 18:32, Tom Herbert wrote: > On Tue, Oct 27, 2015 at 9:44 AM, Hannes Frederic Sowa > wrote: > > > > > > On Tue, Oct 27, 2015, at 17:36, Tom Herbert wrote:> > - if > > (cork->length + length > maxnonfragsize - headersize) { > >> > +

Re: [PATCH net v2 3/4] ipv6: no CHECKSUM_PARTIAL on MSG_MORE corked sockets

2015-10-27 Thread Hannes Frederic Sowa
On Tue, Oct 27, 2015, at 17:36, Tom Herbert wrote:> > - if (cork->length + length > maxnonfragsize - headersize) { > > + if (cork->length + length > maxnonfragsize - headersize) { > > emsgsize: > > - ipv6_local_error(sk, EMSGSIZE, fl6, > > -

Re: [PATCH net v2 3/4] ipv6: no CHECKSUM_PARTIAL on MSG_MORE corked sockets

2015-10-27 Thread Hannes Frederic Sowa
On Tue, Oct 27, 2015, at 19:37, Tom Herbert wrote: > On Tue, Oct 27, 2015 at 11:29 AM, Hannes Frederic Sowa > wrote: > > On Tue, Oct 27, 2015, at 18:32, Tom Herbert wrote: > >> On Tue, Oct 27, 2015 at 9:44 AM, Hannes Frederic Sowa > >>

Re: [PATCH net v2 3/4] ipv6: no CHECKSUM_PARTIAL on MSG_MORE corked sockets

2015-10-27 Thread Tom Herbert
On Tue, Oct 27, 2015 at 2:42 PM, Hannes Frederic Sowa wrote: > Hi Tom, > > On Tue, Oct 27, 2015, at 20:19, Hannes Frederic Sowa wrote: >> On Tue, Oct 27, 2015, at 19:37, Tom Herbert wrote: >> > On Tue, Oct 27, 2015 at 11:29 AM, Hannes Frederic Sowa >> >

Re: [PATCH net v2 3/4] ipv6: no CHECKSUM_PARTIAL on MSG_MORE corked sockets

2015-10-27 Thread Hannes Frederic Sowa
Hi Tom, On Tue, Oct 27, 2015, at 20:19, Hannes Frederic Sowa wrote: > On Tue, Oct 27, 2015, at 19:37, Tom Herbert wrote: > > On Tue, Oct 27, 2015 at 11:29 AM, Hannes Frederic Sowa > > wrote: > > > On Tue, Oct 27, 2015, at 18:32, Tom Herbert wrote: > > >> On Tue, Oct

Re: [PATCH net v2 3/4] ipv6: no CHECKSUM_PARTIAL on MSG_MORE corked sockets

2015-10-27 Thread Tom Herbert
On Tue, Oct 27, 2015 at 5:12 PM, Hannes Frederic Sowa wrote: > On Tue, Oct 27, 2015, at 23:03, Tom Herbert wrote: >> On Tue, Oct 27, 2015 at 2:42 PM, Hannes Frederic Sowa >> wrote: >> > I posted v3 just now. I would like to let David

Re: [PATCH net v2 3/4] ipv6: no CHECKSUM_PARTIAL on MSG_MORE corked sockets

2015-10-27 Thread Hannes Frederic Sowa
On Tue, Oct 27, 2015, at 23:03, Tom Herbert wrote: > On Tue, Oct 27, 2015 at 2:42 PM, Hannes Frederic Sowa > wrote: > > I posted v3 just now. I would like to let David consider it for net > > inclusion. We can work on how to lift this limitation then in net-next, > >