Re: [PATCH net v2 9/9] net: ethernet: mediatek: fix error handling inside mtk_mdio_init

On Mon, Aug 29, 2016 at 01:03:23PM +0800, sean.w...@mediatek.com wrote: > From: Sean Wang > > return -ENODEV if no child is found in MDIO bus. The "no child" is wrong here, and got me confused. What the code is actually doing is of_device_is_available() which is looking

Re: [PATCH net v2 9/9] net: ethernet: mediatek: fix error handling inside mtk_mdio_init

Date: Mon, 29 Aug 2016 15:15:58 +0200,Andrew Lunn wrote: >On Mon, Aug 29, 2016 at 01:03:23PM +0800, sean.w...@mediatek.com wrote: >> From: Sean Wang >> >> return -ENODEV if no child is found in MDIO bus. > >Hi Sean > >Why is it an error not to have any children on the

Re: [PATCH net v2 9/9] net: ethernet: mediatek: fix error handling inside mtk_mdio_init

On Mon, Aug 29, 2016 at 01:03:23PM +0800, sean.w...@mediatek.com wrote: > From: Sean Wang > > return -ENODEV if no child is found in MDIO bus. Hi Sean Why is it an error not to have any children on the bus? Say i have a fibre optical module connected to the MAC. It is

[PATCH net v2 9/9] net: ethernet: mediatek: fix error handling inside mtk_mdio_init

From: Sean Wang return -ENODEV if no child is found in MDIO bus. Signed-off-by: Sean Wang Acked-by: John Crispin --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git