Re: [PATCH net v3 1/2] rhashtable: Fix rhlist duplicates insertion

2018-03-05 Thread Herbert Xu
On Sun, Mar 04, 2018 at 05:29:48PM +0200, Paul Blakey wrote: > When inserting duplicate objects (those with the same key), > current rhlist implementation messes up the chain pointers by > updating the bucket pointer instead of prev next pointer to the > newly inserted node. This causes missing

[PATCH net v3 1/2] rhashtable: Fix rhlist duplicates insertion

2018-03-04 Thread Paul Blakey
When inserting duplicate objects (those with the same key), current rhlist implementation messes up the chain pointers by updating the bucket pointer instead of prev next pointer to the newly inserted node. This causes missing elements on removal and travesal. Fix that by properly updating pprev