RE: [PATCH nf v3 1/1] netfilter: snmp: Fix one possible panic when snmp_trap_helper fail to register

2017-03-24 Thread Gao Feng
ubject: Re: [PATCH nf v3 1/1] netfilter: snmp: Fix one possible panic when > snmp_trap_helper fail to register > > On Tue, Mar 21, 2017 at 08:22:29AM +0800, f...@ikuai8.com wrote: > > From: Gao Feng <f...@ikuai8.com> > > > > In the commit 93557f53e1fb (

Re: [PATCH nf v3 1/1] netfilter: snmp: Fix one possible panic when snmp_trap_helper fail to register

2017-03-24 Thread Pablo Neira Ayuso
On Tue, Mar 21, 2017 at 08:22:29AM +0800, f...@ikuai8.com wrote: > From: Gao Feng > > In the commit 93557f53e1fb ("netfilter: nf_conntrack: nf_conntrack snmp > helper"), the snmp_helper is replaced by nf_nat_snmp_hook. So the > snmp_helper is never registered. But it still tries

RE: [PATCH nf v3 1/1] netfilter: snmp: Fix one possible panic when snmp_trap_helper fail to register

2017-03-24 Thread Gao Feng
.com; netfilter-de...@vger.kernel.org; > netdev@vger.kernel.org; gfree.w...@gmail.com > Subject: Re: [PATCH nf v3 1/1] netfilter: snmp: Fix one possible panic when > snmp_trap_helper fail to register > > On Fri, Mar 24, 2017 at 01:21:30PM +0100, Pablo Neira Ayuso wrote: > > On Tue, Mar 21

Re: [PATCH nf v3 1/1] netfilter: snmp: Fix one possible panic when snmp_trap_helper fail to register

2017-03-24 Thread Pablo Neira Ayuso
On Fri, Mar 24, 2017 at 01:21:30PM +0100, Pablo Neira Ayuso wrote: > On Tue, Mar 21, 2017 at 08:22:29AM +0800, f...@ikuai8.com wrote: > > From: Gao Feng > > > > In the commit 93557f53e1fb ("netfilter: nf_conntrack: nf_conntrack snmp > > helper"), the snmp_helper is replaced by

Re: [PATCH nf v3 1/1] netfilter: snmp: Fix one possible panic when snmp_trap_helper fail to register

2017-03-24 Thread Pablo Neira Ayuso
On Tue, Mar 21, 2017 at 08:22:29AM +0800, f...@ikuai8.com wrote: > From: Gao Feng > > In the commit 93557f53e1fb ("netfilter: nf_conntrack: nf_conntrack snmp > helper"), the snmp_helper is replaced by nf_nat_snmp_hook. So the > snmp_helper is never registered. But it still tries

[PATCH nf v3 1/1] netfilter: snmp: Fix one possible panic when snmp_trap_helper fail to register

2017-03-20 Thread fgao
From: Gao Feng In the commit 93557f53e1fb ("netfilter: nf_conntrack: nf_conntrack snmp helper"), the snmp_helper is replaced by nf_nat_snmp_hook. So the snmp_helper is never registered. But it still tries to unregister the snmp_helper, it could cause the panic. Now remove the