Re: [PATCH rfc 1/4] net/utils: generic inet_pton_with_scope helper

2017-02-21 Thread Christoph Hellwig
On Tue, Feb 21, 2017 at 11:18:04PM +0200, Sagi Grimberg wrote: > I can maybe do something like: > > if (af == AF_INET || af == AF_UNSPEC) { > ret = inet4_pton(); > if (!ret) > return 0; > else if (af != AF_UNSPEC) > return ret; > } > > if (af ==

Re: [PATCH rfc 1/4] net/utils: generic inet_pton_with_scope helper

2017-02-21 Thread Sagi Grimberg
On 19/02/17 19:15, Christoph Hellwig wrote: On Thu, Feb 16, 2017 at 07:43:34PM +0200, Sagi Grimberg wrote: Several locations in the stack need to handle ipv4/ipv6 (with scope) and port strings conversion to sockaddr. Add a helper that takes either AF_INET, AF_INET6 or AF_UNSPEC (for wildcard)

Re: [PATCH rfc 1/4] net/utils: generic inet_pton_with_scope helper

2017-02-19 Thread Christoph Hellwig
On Thu, Feb 16, 2017 at 07:43:34PM +0200, Sagi Grimberg wrote: > Several locations in the stack need to handle ipv4/ipv6 > (with scope) and port strings conversion to sockaddr. > Add a helper that takes either AF_INET, AF_INET6 or > AF_UNSPEC (for wildcard) to centralize this handling. > >

Re: [PATCH rfc 1/4] net/utils: generic inet_pton_with_scope helper

2017-02-16 Thread kbuild test robot
Hi Sagi, [auto build test WARNING on linus/master] [also build test WARNING on v4.10-rc8 next-20170216] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH rfc 1/4] net/utils: generic inet_pton_with_scope helper

2017-02-16 Thread Sagi Grimberg
Several locations in the stack need to handle ipv4/ipv6 (with scope) and port strings conversion to sockaddr. Add a helper that takes either AF_INET, AF_INET6 or AF_UNSPEC (for wildcard) to centralize this handling. Suggested-by: Christoph Hellwig Signed-off-by: Sagi Grimberg