Re: [PATCH rfc 5/6] block: Add rdma affinity based queue mapping helper

2017-04-06 Thread Sagi Grimberg
shouldn't you include and like in commit 8ec2ef2b66ea2f that fixes blk-mq-pci.c ? Not really. We can lose these from blk-mq-pci.c as well. +#include +#include +#include +#include +#include "blk-mq.h" Is this include needed ? You're right, I can just keep: +#include +#include

Re: [PATCH rfc 5/6] block: Add rdma affinity based queue mapping helper

2017-04-05 Thread Jens Axboe
On 04/02/2017 07:41 AM, Sagi Grimberg wrote: > Like pci and virtio, we add a rdma helper for affinity > spreading. This achieves optimal mq affinity assignments > according to the underlying rdma device affinity maps. Reviewed-by: Jens Axboe -- Jens Axboe

Re: [PATCH rfc 5/6] block: Add rdma affinity based queue mapping helper

2017-04-04 Thread Christoph Hellwig
On Tue, Apr 04, 2017 at 10:46:54AM +0300, Max Gurtovoy wrote: >> +if (set->nr_hw_queues > dev->num_comp_vectors) >> +goto fallback; >> + >> +for (queue = 0; queue < set->nr_hw_queues; queue++) { >> +mask = ib_get_vector_affinity(dev, first_vec + queue); >> +

Re: [PATCH rfc 5/6] block: Add rdma affinity based queue mapping helper

2017-04-04 Thread Max Gurtovoy
diff --git a/block/blk-mq-rdma.c b/block/blk-mq-rdma.c new file mode 100644 index ..d402f7c93528 --- /dev/null +++ b/block/blk-mq-rdma.c @@ -0,0 +1,56 @@ +/* + * Copyright (c) 2017 Sagi Grimberg. + * + * This program is free software; you can redistribute it and/or modify it + *

Re: [PATCH rfc 5/6] block: Add rdma affinity based queue mapping helper

2017-04-04 Thread Christoph Hellwig
On Sun, Apr 02, 2017 at 04:41:31PM +0300, Sagi Grimberg wrote: > Like pci and virtio, we add a rdma helper for affinity > spreading. This achieves optimal mq affinity assignments > according to the underlying rdma device affinity maps. > > Signed-off-by: Sagi Grimberg > --- >

[PATCH rfc 5/6] block: Add rdma affinity based queue mapping helper

2017-04-02 Thread Sagi Grimberg
Like pci and virtio, we add a rdma helper for affinity spreading. This achieves optimal mq affinity assignments according to the underlying rdma device affinity maps. Signed-off-by: Sagi Grimberg --- block/Kconfig | 5 block/Makefile | 1 +