Re: [PATCH stable <= 3.18] net: add length argument to skb_copy_and_csum_datagram_iovec

Hello Eric 2015-11-12, 09:26:42 -0800, Eric Dumazet wrote: > Note that the following patch (and corresponding part for ipv6) might > also have solve the issue ? > > This would supposedly save some cycles when MSG_PEEK is used and user > provides short buffers. Your patch looks correct to me,

Re: [PATCH stable <= 3.18] net: add length argument to skb_copy_and_csum_datagram_iovec

On Thu, 2015-10-15 at 14:25 +0200, Sabrina Dubroca wrote: > Without this length argument, we can read past the end of the iovec > in > memcpy_toiovec because we have no way of knowing the total length of > the > iovec's buffers. > > This is needed for stable kernels where 89c22d8c3b27 ("net: Fix

Re: [PATCH stable <= 3.18] net: add length argument to skb_copy_and_csum_datagram_iovec

From: Sabrina Dubroca Date: Thu, 12 Nov 2015 10:48:22 +0100 > 2015-11-10, 16:03:52 -0800, Greg Kroah-Hartman wrote: >> On Tue, Nov 10, 2015 at 05:59:26PM -0600, Josh Hunt wrote: >> > On Thu, Oct 29, 2015 at 5:00 AM, Sabrina Dubroca >> > wrote: >> > >

Re: [PATCH stable <= 3.18] net: add length argument to skb_copy_and_csum_datagram_iovec

2015-11-10, 16:03:52 -0800, Greg Kroah-Hartman wrote: > On Tue, Nov 10, 2015 at 05:59:26PM -0600, Josh Hunt wrote: > > On Thu, Oct 29, 2015 at 5:00 AM, Sabrina Dubroca > > wrote: > > > 2015-10-15, 14:25:03 +0200, Sabrina Dubroca wrote: > > >> Without this length argument,

Re: [PATCH stable <= 3.18] net: add length argument to skb_copy_and_csum_datagram_iovec

On Thu, 2015-11-12 at 10:48 +0100, Sabrina Dubroca wrote: > 2015-11-10, 16:03:52 -0800, Greg Kroah-Hartman wrote: > > On Tue, Nov 10, 2015 at 05:59:26PM -0600, Josh Hunt wrote: > > > On Thu, Oct 29, 2015 at 5:00 AM, Sabrina Dubroca > > > wrote: > > > > 2015-10-15, 14:25:03

Re: [PATCH stable <= 3.18] net: add length argument to skb_copy_and_csum_datagram_iovec

On Thu, Oct 29, 2015 at 5:00 AM, Sabrina Dubroca wrote: > 2015-10-15, 14:25:03 +0200, Sabrina Dubroca wrote: >> Without this length argument, we can read past the end of the iovec in >> memcpy_toiovec because we have no way of knowing the total length of the >> iovec's

Re: [PATCH stable <= 3.18] net: add length argument to skb_copy_and_csum_datagram_iovec

2015-10-15, 14:25:03 +0200, Sabrina Dubroca wrote: > Without this length argument, we can read past the end of the iovec in > memcpy_toiovec because we have no way of knowing the total length of the > iovec's buffers. > > This is needed for stable kernels where 89c22d8c3b27 ("net: Fix skb > csum

[PATCH stable <= 3.18] net: add length argument to skb_copy_and_csum_datagram_iovec

Without this length argument, we can read past the end of the iovec in memcpy_toiovec because we have no way of knowing the total length of the iovec's buffers. This is needed for stable kernels where 89c22d8c3b27 ("net: Fix skb csum races when peeking") has been backported but that don't have