Re: [PATCH v1 3/8] crypto:chcr- Fix key length for RFC4106

2017-01-12 Thread Herbert Xu
On Thu, Jan 12, 2017 at 10:08:46PM +0530, Harsh Jain wrote: > > That case is already handled in next if condition.It will error out with > -EINVAL in next condition. > > if (keylen == AES_KEYSIZE_128) { Good point. Please split the patches according to whether they should go into 4.10/4.11 and

Re: [PATCH v1 3/8] crypto:chcr- Fix key length for RFC4106

2017-01-12 Thread Harsh Jain
On 12-01-2017 21:39, Herbert Xu wrote: > On Fri, Jan 06, 2017 at 02:01:34PM +0530, Harsh Jain wrote: >> Check keylen before copying salt to avoid wrap around of Integer. >> >> Signed-off-by: Harsh Jain >> --- >> drivers/crypto/chelsio/chcr_algo.c | 4 ++-- >> 1 file changed,

Re: [PATCH v1 3/8] crypto:chcr- Fix key length for RFC4106

2017-01-12 Thread Herbert Xu
On Fri, Jan 06, 2017 at 02:01:34PM +0530, Harsh Jain wrote: > Check keylen before copying salt to avoid wrap around of Integer. > > Signed-off-by: Harsh Jain > --- > drivers/crypto/chelsio/chcr_algo.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

[PATCH v1 3/8] crypto:chcr- Fix key length for RFC4106

2017-01-06 Thread Harsh Jain
Check keylen before copying salt to avoid wrap around of Integer. Signed-off-by: Harsh Jain --- drivers/crypto/chelsio/chcr_algo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/chelsio/chcr_algo.c b/drivers/crypto/chelsio/chcr_algo.c