> I notice 2 problems in the driver:
>
> 1. netif_napi_add is used instead of netif_tx_napi_add.
> 2. In all other drivers that use netif_tx_napi_add most do not call
> napi_complete_done.
> They all call napi_complete directly and return 0.
>
> freescale/gianfar.c
> rocker/rocker_main.c
> ti/cps
> Did you look at the output of "perf top" or something along those lines to
> figure out if your lan743x driver is indeed responsible for that by not being
> scheduler friendly? What is likely happening is that you do not reclaim
> "weight" packets and instead keep looping into NAPI context, which
From:
Date: Wed, 21 Nov 2018 02:13:30 +
> Slightly out of topic I am not sure why NAPI is used on the transmit side.
> Originally NAPI was designed to fix the receive interrupt happening on each
> receive frame problem, so on transmit side it is to avoid the transmit
> done interrupt on each
2 PM
> To: Bryan Whitehead - C21958 ;
> and...@lunn.ch
> Cc: da...@davemloft.net; netdev@vger.kernel.org; UNGLinuxDriver
>
> Subject: Re: [PATCH v1 net] lan743x: fix return value for
> lan743x_tx_napi_poll
>
> On 11/20/18 1:39 PM, bryan.whiteh...@microchip.com wrote:
> >
t;> Subject: Re: [PATCH v1 net] lan743x: fix return value for
>> lan743x_tx_napi_poll
>>
>> On Tue, Nov 20, 2018 at 01:26:43PM -0500, Bryan Whitehead wrote:
>>> It has been noticed that under stress the lan743x driver will
>>> sometimes hang or cause a kernel pa
> Andrew,
>
> Admittedly, my knowledge of what the kernel is doing behind the
> scenes is limited.
Me too. Lets see if anybody can make sense of the information you
provided.
Thanks
Andrew
> -Original Message-
> From: Andrew Lunn
> Sent: Tuesday, November 20, 2018 2:31 PM
> To: Bryan Whitehead - C21958
> Cc: da...@davemloft.net; netdev@vger.kernel.org; UNGLinuxDriver
>
> Subject: Re: [PATCH v1 net] lan743x: fix return value for
> lan743x_tx_napi_
On Tue, Nov 20, 2018 at 01:26:43PM -0500, Bryan Whitehead wrote:
> It has been noticed that under stress the lan743x driver will
> sometimes hang or cause a kernel panic. It has been noticed
> that returning '0' instead of 'weight' fixes this issue.
>
> fixes: rare kernel panic under heavy traffic
It has been noticed that under stress the lan743x driver will
sometimes hang or cause a kernel panic. It has been noticed
that returning '0' instead of 'weight' fixes this issue.
fixes: rare kernel panic under heavy traffic load.
Signed-off-by: Bryan Whitehead
---
drivers/net/ethernet/microchip/
