Re: [PATCH v1 net-next 12/14] igb: Only call skb_tx_timestamp after descriptors are ready

2018-06-28 Thread Jesus Sanchez-Palencia
On 06/27/2018 04:56 PM, Eric Dumazet wrote: > > > On 06/27/2018 02:59 PM, Jesus Sanchez-Palencia wrote: >> Currently, skb_tx_timestamp() is being called before the DMA >> descriptors are prepared in igb_xmit_frame_ring(), which happens >> during either the igb_tso() or igb_tx_csum() calls. >>

Re: [PATCH v1 net-next 12/14] igb: Only call skb_tx_timestamp after descriptors are ready

2018-06-27 Thread Eric Dumazet
On 06/27/2018 02:59 PM, Jesus Sanchez-Palencia wrote: > Currently, skb_tx_timestamp() is being called before the DMA > descriptors are prepared in igb_xmit_frame_ring(), which happens > during either the igb_tso() or igb_tx_csum() calls. > > Given that now the skb->tstamp might be used to carry

[PATCH v1 net-next 12/14] igb: Only call skb_tx_timestamp after descriptors are ready

2018-06-27 Thread Jesus Sanchez-Palencia
Currently, skb_tx_timestamp() is being called before the DMA descriptors are prepared in igb_xmit_frame_ring(), which happens during either the igb_tso() or igb_tx_csum() calls. Given that now the skb->tstamp might be used to carry the timestamp for SO_TXTIME, we must only call skb_tx_timestamp()