Re: [PATCH v1 net-next 14/14] net/sched: Make etf report drops on error_queue

2018-06-29 Thread Jesus Sanchez-Palencia
On 06/29/2018 11:49 AM, Willem de Bruijn wrote: diff --git a/net/sched/sch_etf.c b/net/sched/sch_etf.c +static void report_sock_error(struct sk_buff *skb, u32 err, u8 code) +{ + struct sock_exterr_skb *serr; + ktime_t txtime = skb->tstamp; + +

Re: [PATCH v1 net-next 14/14] net/sched: Make etf report drops on error_queue

2018-06-29 Thread Willem de Bruijn
> >> diff --git a/net/sched/sch_etf.c b/net/sched/sch_etf.c > >> index 5514a8aa3bd5..166f4b72875b 100644 > >> --- a/net/sched/sch_etf.c > >> +++ b/net/sched/sch_etf.c > >> @@ -11,6 +11,7 @@ > >> #include > >> #include > >> #include > >> +#include > >> #include > >> #include > >> #includ

Re: [PATCH v1 net-next 14/14] net/sched: Make etf report drops on error_queue

2018-06-29 Thread Jesus Sanchez-Palencia
Hi Willem, On 06/28/2018 07:27 AM, Willem de Bruijn wrote: (...) > >> struct sock_txtime { >> clockid_t clockid;/* reference clockid */ >> - u16 flags; /* bit 0: txtime in deadline_mode */ >> + u16 flags; /* bit 0: tx

Re: [PATCH v1 net-next 14/14] net/sched: Make etf report drops on error_queue

2018-06-28 Thread Willem de Bruijn
On Wed, Jun 27, 2018 at 6:07 PM Jesus Sanchez-Palencia wrote: > > Use the socket error queue for reporting dropped packets if the > socket has enabled that feature through the SO_TXTIME API. > > Packets are dropped either on enqueue() if they aren't accepted by the > qdisc or on dequeue() if the s

[PATCH v1 net-next 14/14] net/sched: Make etf report drops on error_queue

2018-06-27 Thread Jesus Sanchez-Palencia
Use the socket error queue for reporting dropped packets if the socket has enabled that feature through the SO_TXTIME API. Packets are dropped either on enqueue() if they aren't accepted by the qdisc or on dequeue() if the system misses their deadline. Those are reported as different errors so app