Re: [PATCH v10 12/12] bpf: add sample for xdp forwarding and rewrite

2016-08-03 Thread Daniel Borkmann
On 08/04/2016 12:36 AM, Alexei Starovoitov wrote: On Wed, Aug 03, 2016 at 12:06:55PM -0700, Tom Herbert wrote: [...] This is not at all obvious to XDP programmer. The type of ctx structure is xdp_md and the definition of that structure in uapi/linux/bpf.h says that the fields in the that

Re: [PATCH v10 12/12] bpf: add sample for xdp forwarding and rewrite

2016-08-03 Thread Alexei Starovoitov
On Wed, Aug 03, 2016 at 12:06:55PM -0700, Tom Herbert wrote: > On Wed, Aug 3, 2016 at 11:29 AM, Brenden Blanco wrote: > > On Wed, Aug 03, 2016 at 10:29:58AM -0700, Tom Herbert wrote: > >> On Wed, Aug 3, 2016 at 10:11 AM, Alexei Starovoitov > >>

Re: [PATCH v10 12/12] bpf: add sample for xdp forwarding and rewrite

2016-08-03 Thread Tom Herbert
On Wed, Aug 3, 2016 at 11:29 AM, Brenden Blanco wrote: > On Wed, Aug 03, 2016 at 10:29:58AM -0700, Tom Herbert wrote: >> On Wed, Aug 3, 2016 at 10:11 AM, Alexei Starovoitov >> wrote: >> > On Wed, Aug 03, 2016 at 10:01:54AM -0700, Tom Herbert

Re: [PATCH v10 12/12] bpf: add sample for xdp forwarding and rewrite

2016-08-03 Thread Brenden Blanco
On Wed, Aug 03, 2016 at 10:29:58AM -0700, Tom Herbert wrote: > On Wed, Aug 3, 2016 at 10:11 AM, Alexei Starovoitov > wrote: > > On Wed, Aug 03, 2016 at 10:01:54AM -0700, Tom Herbert wrote: > >> On Tue, Jul 19, 2016 at 12:16 PM, Brenden Blanco

Re: [PATCH v10 12/12] bpf: add sample for xdp forwarding and rewrite

2016-08-03 Thread David Miller
From: Brenden Blanco Date: Wed, 3 Aug 2016 11:29:52 -0700 > On Wed, Aug 03, 2016 at 10:29:58AM -0700, Tom Herbert wrote: >> On Wed, Aug 3, 2016 at 10:11 AM, Alexei Starovoitov >> wrote: >> > On Wed, Aug 03, 2016 at 10:01:54AM -0700, Tom

Re: [PATCH v10 12/12] bpf: add sample for xdp forwarding and rewrite

2016-08-03 Thread David Miller
From: Tom Herbert Date: Wed, 3 Aug 2016 10:29:58 -0700 > On Wed, Aug 3, 2016 at 10:11 AM, Alexei Starovoitov > wrote: >> On Wed, Aug 03, 2016 at 10:01:54AM -0700, Tom Herbert wrote: >>> On Tue, Jul 19, 2016 at 12:16 PM, Brenden Blanco

Re: [PATCH v10 12/12] bpf: add sample for xdp forwarding and rewrite

2016-08-03 Thread Tom Herbert
On Tue, Jul 19, 2016 at 12:16 PM, Brenden Blanco wrote: > Add a sample that rewrites and forwards packets out on the same > interface. Observed single core forwarding performance of ~10Mpps. > > Since the mlx4 driver under test recycles every single packet page, the > perf

Re: [PATCH v10 12/12] bpf: add sample for xdp forwarding and rewrite

2016-08-03 Thread Tom Herbert
On Wed, Aug 3, 2016 at 10:11 AM, Alexei Starovoitov wrote: > On Wed, Aug 03, 2016 at 10:01:54AM -0700, Tom Herbert wrote: >> On Tue, Jul 19, 2016 at 12:16 PM, Brenden Blanco >> wrote: >> > Add a sample that rewrites and forwards packets out on

Re: [PATCH v10 12/12] bpf: add sample for xdp forwarding and rewrite

2016-08-03 Thread Alexei Starovoitov
On Wed, Aug 03, 2016 at 10:01:54AM -0700, Tom Herbert wrote: > On Tue, Jul 19, 2016 at 12:16 PM, Brenden Blanco wrote: > > Add a sample that rewrites and forwards packets out on the same > > interface. Observed single core forwarding performance of ~10Mpps. > > > > Since the

Re: [PATCH v10 12/12] bpf: add sample for xdp forwarding and rewrite

2016-07-27 Thread Jesper Dangaard Brouer
On Tue, 19 Jul 2016 15:05:37 -0700 Alexei Starovoitov wrote: > On Tue, Jul 19, 2016 at 12:16:57PM -0700, Brenden Blanco wrote: > > Add a sample that rewrites and forwards packets out on the same > > interface. Observed single core forwarding performance of ~10Mpps.

Re: [PATCH v10 12/12] bpf: add sample for xdp forwarding and rewrite

2016-07-20 Thread Brenden Blanco
On Tue, Jul 19, 2016 at 03:05:37PM -0700, Alexei Starovoitov wrote: > On Tue, Jul 19, 2016 at 12:16:57PM -0700, Brenden Blanco wrote: > > Add a sample that rewrites and forwards packets out on the same > > interface. Observed single core forwarding performance of ~10Mpps. > > > > Since the mlx4

Re: [PATCH v10 12/12] bpf: add sample for xdp forwarding and rewrite

2016-07-19 Thread Alexei Starovoitov
On Tue, Jul 19, 2016 at 12:16:57PM -0700, Brenden Blanco wrote: > Add a sample that rewrites and forwards packets out on the same > interface. Observed single core forwarding performance of ~10Mpps. > > Since the mlx4 driver under test recycles every single packet page, the > perf output shows

[PATCH v10 12/12] bpf: add sample for xdp forwarding and rewrite

2016-07-19 Thread Brenden Blanco
Add a sample that rewrites and forwards packets out on the same interface. Observed single core forwarding performance of ~10Mpps. Since the mlx4 driver under test recycles every single packet page, the perf output shows almost exclusively just the ring management and bpf program work. Slowdowns