Olof Johansson wrote:
Move away from using the pci config access functions for simple register
access. Our device has all of the registers in the config space (hey,
from the hardware point of view it looks reasonable :-), so we need to
somehow get to it. Newer firmwares have it in the device
On Fri, Aug 24, 2007 at 02:05:31PM +1000, Stephen Rothwell wrote:
On Thu, 23 Aug 2007 13:13:10 -0500 Olof Johansson [EMAIL PROTECTED] wrote:
out:
- pci_dev_put(mac-iob_pdev);
-out_put_dma_pdev:
- pci_dev_put(mac-dma_pdev);
-out_free_netdev:
+ if (mac-iob_pdev)
+
On Fri, 24 Aug 2007 13:11:04 -0500 Olof Johansson [EMAIL PROTECTED] wrote:
On Fri, Aug 24, 2007 at 02:05:31PM +1000, Stephen Rothwell wrote:
It is not documented as such (as far as I can see), but pci_dev_put is
safe to call with NULL. And there are other places in the kernel that
Move away from using the pci config access functions for simple register
access. Our device has all of the registers in the config space (hey,
from the hardware point of view it looks reasonable :-), so we need to
somehow get to it. Newer firmwares have it in the device tree such that
we can just
On Thu, 23 Aug 2007 13:13:10 -0500 Olof Johansson [EMAIL PROTECTED] wrote:
out:
- pci_dev_put(mac-iob_pdev);
-out_put_dma_pdev:
- pci_dev_put(mac-dma_pdev);
-out_free_netdev:
+ if (mac-iob_pdev)
+ pci_dev_put(mac-iob_pdev);
+ if (mac-dma_pdev)
+
