Re: [PATCH v2] net: ibm: emac: Fix some error handling path in 'emac_probe()'

2017-08-20 Thread David Miller
From: Christophe JAILLET Date: Sun, 20 Aug 2017 06:35:00 +0200 > If 'irq_of_parse_and_map()' or 'of_address_to_resource()' fail, 'err' is > known to be 0 at this point. > So return -ENODEV instead in the first case and use 'of_iomap()' instead of > the equivalent

[PATCH v2] net: ibm: emac: Fix some error handling path in 'emac_probe()'

2017-08-19 Thread Christophe JAILLET
If 'irq_of_parse_and_map()' or 'of_address_to_resource()' fail, 'err' is known to be 0 at this point. So return -ENODEV instead in the first case and use 'of_iomap()' instead of the equivalent 'of_address_to_resource()/ioremap()' combinaison in the 2nd case. Doing so, the 'rsrc_regs' field of the