Re: [PATCH v2 05/11] net: stmmac: dwmac-rk: Add internal phy support

2017-08-01 Thread Chen-Yu Tsai
Hi David, Florian, Andrew (resent in plain text) On Fri, Jul 28, 2017 at 2:56 PM, David.Wu wrote: > > Hi Florian, > > 在 2017/7/28 0:54, Florian Fainelli 写道: >> >> - if you need knowledge about this PHY connection type prior to binding >> the PHY device and its driver

Re: [PATCH v2 05/11] net: stmmac: dwmac-rk: Add internal phy support

2017-07-28 Thread Maxime Ripard
On Thu, Jul 27, 2017 at 07:31:52PM +0200, Corentin Labbe wrote: > On Thu, Jul 27, 2017 at 09:54:01AM -0700, Florian Fainelli wrote: > > On 07/27/2017 06:48 AM, Andrew Lunn wrote: > > > On Thu, Jul 27, 2017 at 09:02:16PM +0800, David Wu wrote: > > >> To make internal phy work, need to configure the

Re: [PATCH v2 05/11] net: stmmac: dwmac-rk: Add internal phy support

2017-07-28 Thread David.Wu
Hi Florian, 在 2017/7/28 0:54, Florian Fainelli 写道: - if you need knowledge about this PHY connection type prior to binding the PHY device and its driver (that is, before of_phy_connect()) we could add a boolean property e.g: "phy-is-internal" that allows us to know that, or we can have a new

Re: [PATCH v2 05/11] net: stmmac: dwmac-rk: Add internal phy support

2017-07-28 Thread David.Wu
Hi Andrew, 在 2017/7/27 21:48, Andrew Lunn 写道: I think we need to discuss this. This PHY appears to be on an MDIO bus, it uses a standard PHY driver, and it appears to be using an RMII interface. So it is just an ordinary PHY. Internal is supposed to be something which is not ordinary, does not

Re: [PATCH v2 05/11] net: stmmac: dwmac-rk: Add internal phy support

2017-07-27 Thread Corentin Labbe
On Thu, Jul 27, 2017 at 09:54:01AM -0700, Florian Fainelli wrote: > On 07/27/2017 06:48 AM, Andrew Lunn wrote: > > On Thu, Jul 27, 2017 at 09:02:16PM +0800, David Wu wrote: > >> To make internal phy work, need to configure the phy_clock, > >> phy cru_reset and related registers. > >> > >>

Re: [PATCH v2 05/11] net: stmmac: dwmac-rk: Add internal phy support

2017-07-27 Thread Florian Fainelli
On 07/27/2017 06:48 AM, Andrew Lunn wrote: > On Thu, Jul 27, 2017 at 09:02:16PM +0800, David Wu wrote: >> To make internal phy work, need to configure the phy_clock, >> phy cru_reset and related registers. >> >> Signed-off-by: David Wu >> --- >> changes in v2: >> - Use

Re: [PATCH v2 05/11] net: stmmac: dwmac-rk: Add internal phy support

2017-07-27 Thread Andrew Lunn
On Thu, Jul 27, 2017 at 09:02:16PM +0800, David Wu wrote: > To make internal phy work, need to configure the phy_clock, > phy cru_reset and related registers. > > Signed-off-by: David Wu > --- > changes in v2: > - Use the standard "phy-mode" property for internal phy.

[PATCH v2 05/11] net: stmmac: dwmac-rk: Add internal phy support

2017-07-27 Thread David Wu
To make internal phy work, need to configure the phy_clock, phy cru_reset and related registers. Signed-off-by: David Wu --- changes in v2: - Use the standard "phy-mode" property for internal phy. (Florian) - Move the internal macphy clock to the optional properties.