Re: [PATCH v2 1/2] seq_file: Introduce DEFINE_SHOW_ATTRIBUTE() helper macro

2017-12-13 Thread Andy Shevchenko
On Tue, 2017-11-28 at 14:19 +0200, Andy Shevchenko wrote: > On Tue, 2017-11-28 at 09:43 +0100, Marcel Holtmann wrote: > > Hi Andy, > > > > > The DEFINE_SHOW_ATTRIBUTE() helper macro would be useful for > > > current > > > users, which are many of them, and for new comers to decrease code > > > dup

Re: [PATCH v2 1/2] seq_file: Introduce DEFINE_SHOW_ATTRIBUTE() helper macro

2017-11-28 Thread Andy Shevchenko
On Tue, 2017-11-28 at 09:43 +0100, Marcel Holtmann wrote: > Hi Andy, > > > The DEFINE_SHOW_ATTRIBUTE() helper macro would be useful for current > > users, which are many of them, and for new comers to decrease code > > duplication. > can we define this in hci_debugfs.c first and get that patch me

Re: [PATCH v2 1/2] seq_file: Introduce DEFINE_SHOW_ATTRIBUTE() helper macro

2017-11-28 Thread Marcel Holtmann
Hi Andy, > The DEFINE_SHOW_ATTRIBUTE() helper macro would be useful for current > users, which are many of them, and for new comers to decrease code > duplication. > > Signed-off-by: Andy Shevchenko > --- > include/linux/seq_file.h | 13 + > 1 file changed, 13 insertions(+) > > diff

[PATCH v2 1/2] seq_file: Introduce DEFINE_SHOW_ATTRIBUTE() helper macro

2017-11-23 Thread Andy Shevchenko
The DEFINE_SHOW_ATTRIBUTE() helper macro would be useful for current users, which are many of them, and for new comers to decrease code duplication. Signed-off-by: Andy Shevchenko --- include/linux/seq_file.h | 13 + 1 file changed, 13 insertions(+) diff --git a/include/linux/seq_fi