Re: [PATCH v2 2/6] net: phy: broadcom: Add BCM54810 PHY entry

2016-11-01 Thread Andrew Lunn
> I'll make the generic string be "enet-phy-lane-swap" (without the > previous "brcm"), and add the flag to phy.txt to document it. Great. Please be quite verbose as to what it means. Thanks Andrew

Re: [PATCH v2 2/6] net: phy: broadcom: Add BCM54810 PHY entry

2016-11-01 Thread Jon Mason
On Tue, Nov 01, 2016 at 05:26:48PM +0100, Andrew Lunn wrote: > > > > + if (of_property_read_bool(np, "brcm,enet-phy-lane-swap")) { > > > > + /* Lane Swap - Undocumented register...magic! */ > > > > + ret = bcm_phy_write_exp(phydev, MII_BCM54XX_EXP_SEL_ER > > > >

Re: [PATCH v2 2/6] net: phy: broadcom: Add BCM54810 PHY entry

2016-11-01 Thread Andrew Lunn
> > > + if (of_property_read_bool(np, "brcm,enet-phy-lane-swap")) { > > > + /* Lane Swap - Undocumented register...magic! */ > > > + ret = bcm_phy_write_exp(phydev, MII_BCM54XX_EXP_SEL_ER + 0x9, > > > + 0x11B); > > > + if (ret < 0) > > > +

Re: [PATCH v2 2/6] net: phy: broadcom: Add BCM54810 PHY entry

2016-11-01 Thread Jon Mason
On Sat, Oct 29, 2016 at 10:18:39AM +0200, Andrew Lunn wrote: > On Fri, Oct 28, 2016 at 04:56:55PM -0400, Jon Mason wrote: > > The BCM54810 PHY requires some semi-unique configuration, which results > > in some additional configuration in addition to the standard config. > > Also, some users of the

Re: [PATCH v2 2/6] net: phy: broadcom: Add BCM54810 PHY entry

2016-10-29 Thread Andrew Lunn
On Fri, Oct 28, 2016 at 04:56:55PM -0400, Jon Mason wrote: > The BCM54810 PHY requires some semi-unique configuration, which results > in some additional configuration in addition to the standard config. > Also, some users of the BCM54810 require the PHY lanes to be swapped. > Since there is no

[PATCH v2 2/6] net: phy: broadcom: Add BCM54810 PHY entry

2016-10-28 Thread Jon Mason
The BCM54810 PHY requires some semi-unique configuration, which results in some additional configuration in addition to the standard config. Also, some users of the BCM54810 require the PHY lanes to be swapped. Since there is no way to detect this, add a device tree query to see if it is