Re: [PATCH v2 22/35] nds32: Device tree support

2017-12-02 Thread Greentime Hu
2017-11-28 3:07 GMT+08:00 Rob Herring : > On Mon, Nov 27, 2017 at 6:28 AM, Greentime Hu wrote: >> From: Greentime Hu >> >> This patch adds support for device tree. >> >> Signed-off-by: Vincent Chen >>

Re: [PATCH v2 22/35] nds32: Device tree support

2017-11-27 Thread Greentime Hu
2017-11-27 22:30 GMT+08:00 Arnd Bergmann : > On Mon, Nov 27, 2017 at 1:28 PM, Greentime Hu wrote: >> @@ -0,0 +1,55 @@ >> +/dts-v1/; >> +/ { >> + compatible = "nds32 ae3xx"; > > The compatible string doesn't seem to match the binding, it should always have

Re: [PATCH v2 22/35] nds32: Device tree support

2017-11-27 Thread Rob Herring
On Mon, Nov 27, 2017 at 1:07 PM, Rob Herring wrote: > On Mon, Nov 27, 2017 at 6:28 AM, Greentime Hu wrote: >> From: Greentime Hu >> >> This patch adds support for device tree. >> >> Signed-off-by: Vincent Chen

Re: [PATCH v2 22/35] nds32: Device tree support

2017-11-27 Thread Rob Herring
On Mon, Nov 27, 2017 at 6:28 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch adds support for device tree. > > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu > --- >

Re: [PATCH v2 22/35] nds32: Device tree support

2017-11-27 Thread Arnd Bergmann
On Mon, Nov 27, 2017 at 1:28 PM, Greentime Hu wrote: > @@ -0,0 +1,55 @@ > +/dts-v1/; > +/ { > + compatible = "nds32 ae3xx"; The compatible string doesn't seem to match the binding, it should always have vendor prefix. > + #address-cells = <1>; > +

[PATCH v2 22/35] nds32: Device tree support

2017-11-27 Thread Greentime Hu
From: Greentime Hu This patch adds support for device tree. Signed-off-by: Vincent Chen Signed-off-by: Greentime Hu --- arch/nds32/boot/dts/Makefile |8 ++ arch/nds32/boot/dts/ae3xx.dts | 55