Re: [PATCH v2 4/5] rds: Add runchecks.cfg for net/rds

2017-12-18 Thread Santosh Shilimkar
On 12/16/2017 6:02 PM, Knut Omang wrote: On Sat, 2017-12-16 at 12:00 -0800, santosh.shilim...@oracle.com wrote: On 12/16/17 10:24 AM, Joe Perches wrote: [...] Most of these existing messages from checkpatch should probably be inspected and corrected where possible to minimize the style

Re: [PATCH v2 4/5] rds: Add runchecks.cfg for net/rds

2017-12-16 Thread Knut Omang
On Sat, 2017-12-16 at 10:24 -0800, Joe Perches wrote: > On Sat, 2017-12-16 at 09:45 -0800, Stephen Hemminger wrote: > > On Sat, 16 Dec 2017 15:42:29 +0100 Knut Omang wrote: > > > +# Code simplification: > > > +# > > > +except ALLOC_WITH_MULTIPLY ib.c > > > +except

Re: [PATCH v2 4/5] rds: Add runchecks.cfg for net/rds

2017-12-16 Thread Knut Omang
On Sat, 2017-12-16 at 12:00 -0800, santosh.shilim...@oracle.com wrote: > On 12/16/17 10:24 AM, Joe Perches wrote: > > On Sat, 2017-12-16 at 09:45 -0800, Stephen Hemminger wrote: > >> On Sat, 16 Dec 2017 15:42:29 +0100 Knut Omang > >> wrote: > >>> +# Code simplification: >

Re: [PATCH v2 4/5] rds: Add runchecks.cfg for net/rds

2017-12-16 Thread Knut Omang
On Sat, 2017-12-16 at 09:45 -0800, Stephen Hemminger wrote: > On Sat, 16 Dec 2017 15:42:29 +0100 > Knut Omang wrote: > > > + > > +# Important to fix from a quality perspective: > > +# > > +except AVOID_BUG connection.c ib.c ib_cm.c ib_rdma.c ib_recv.c ib_ring.c > >

Re: [PATCH v2 4/5] rds: Add runchecks.cfg for net/rds

2017-12-16 Thread santosh.shilim...@oracle.com
On 12/16/17 10:24 AM, Joe Perches wrote: On Sat, 2017-12-16 at 09:45 -0800, Stephen Hemminger wrote: On Sat, 16 Dec 2017 15:42:29 +0100 Knut Omang wrote: +# Code simplification: +# +except ALLOC_WITH_MULTIPLY ib.c +except PREFER_PR_LEVEL ib_cm.c ib_recv.c ib_send.c

Re: [PATCH v2 4/5] rds: Add runchecks.cfg for net/rds

2017-12-16 Thread Joe Perches
On Sat, 2017-12-16 at 09:45 -0800, Stephen Hemminger wrote: > On Sat, 16 Dec 2017 15:42:29 +0100 Knut Omang wrote: > > +# Code simplification: > > +# > > +except ALLOC_WITH_MULTIPLY ib.c > > +except PREFER_PR_LEVEL ib_cm.c ib_recv.c ib_send.c rdma_transport.c > > threads.c

Re: [PATCH v2 4/5] rds: Add runchecks.cfg for net/rds

2017-12-16 Thread Stephen Hemminger
On Sat, 16 Dec 2017 15:42:29 +0100 Knut Omang wrote: > + > +# Important to fix from a quality perspective: > +# > +except AVOID_BUG connection.c ib.c ib_cm.c ib_rdma.c ib_recv.c ib_ring.c > ib_send.c info.c loop.c message.c > +except AVOID_BUG rdma.c recv.c send.c stats.c

[PATCH v2 4/5] rds: Add runchecks.cfg for net/rds

2017-12-16 Thread Knut Omang
Add a runchecks.cfg to net/rds to start "reining in" future checker errors, and making it easier to selectively clean up existing issues. This runchecks.cfg lets make C=2 M=net/rds pass with all errors/warnings suppressed See Documentation/dev-tools/runchecks.rst for motivation and details.