Re: [PATCH v2 bpf-next 2/2] bpf: add selftest for stackmap with build_id in NMI context

2018-05-04 Thread Song Liu
Thanks Tobin. I will fold these changes in. > On May 3, 2018, at 12:19 AM, Tobin C. Harding wrote: > > On Wed, May 02, 2018 at 04:20:30PM -0700, Song Liu wrote: >> This new test captures stackmap with build_id with hardware event >> PERF_COUNT_HW_CPU_CYCLES. >> >> Because

Re: [PATCH v2 bpf-next 2/2] bpf: add selftest for stackmap with build_id in NMI context

2018-05-03 Thread Tobin C. Harding
On Wed, May 02, 2018 at 04:20:30PM -0700, Song Liu wrote: > This new test captures stackmap with build_id with hardware event > PERF_COUNT_HW_CPU_CYCLES. > > Because we only support one ips-to-build_id lookup per cpu in NMI > context, stack_amap will not be able to do the lookup in this test.

[PATCH v2 bpf-next 2/2] bpf: add selftest for stackmap with build_id in NMI context

2018-05-02 Thread Song Liu
This new test captures stackmap with build_id with hardware event PERF_COUNT_HW_CPU_CYCLES. Because we only support one ips-to-build_id lookup per cpu in NMI context, stack_amap will not be able to do the lookup in this test. Therefore, we didn't do compare_stack_ips(), as it will alwasy fail.